From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DBD831FF141 for ; Tue, 05 May 2026 10:42:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 951C21ED92; Tue, 5 May 2026 10:42:15 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Subject: [PATCH pve-manager v5 18/27] pveupdate: refresh notification targets' OAuth2 state Date: Tue, 5 May 2026 10:32:39 +0200 Message-ID: <20260505083248.36450-19-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260505083248.36450-1-a.bied-charreton@proxmox.com> References: <20260505083248.36450-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: WEBDWYM6SZHGYJUZOHAEUQEYRLVGAUQZ X-Message-ID-Hash: WEBDWYM6SZHGYJUZOHAEUQEYRLVGAUQZ X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Avoid OAuth2 refresh token expiry by forcing a notification target refresh in PVE's daily-update job. This is done under a notifications config lock because failure to do so may result in the state file updates happening concurrently with other configuration file updates, leading to, for example, a stale state file if an endpoint was deleted in the meantime. Signed-off-by: Arthur Bied-Charreton --- bin/pveupdate | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/bin/pveupdate b/bin/pveupdate index b1960c35..25cd4f21 100755 --- a/bin/pveupdate +++ b/bin/pveupdate @@ -195,4 +195,17 @@ sub cleanup_tasks { cleanup_tasks(); +eval { + PVE::Notify::lock_config(sub { + my $config = PVE::Notify::read_config(); + # Refresh internal state for notification targets. This writes the + # state files for SMTP XOAUTH2 endpoints, which we do not want to + # happen concurrently with config R/W cycles. + $config->trigger_state_refresh(); + }); +}; +if (my $err = $@) { + syslog('err', "refresh notification targets failed: $err"); +} + exit(0); -- 2.47.3