From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DFCFD1FF136 for ; Mon, 04 May 2026 18:33:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A1017C029; Mon, 4 May 2026 18:32:40 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 8/9] ui: sdn: fabric edit: allow defining multiple tabs Date: Mon, 4 May 2026 18:31:53 +0200 Message-ID: <20260504163157.429628-9-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260504163157.429628-1-s.hanreich@proxmox.com> References: <20260504163157.429628-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777912219993 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.657 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HHJI32DDPF4QARIVK7M6W6M2ETOHFXMM X-Message-ID-Hash: HHJI32DDPF4QARIVK7M6W6M2ETOHFXMM X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This allows for adding multiple tabs to the fabric edit window, which can be used to include additional settings to the create/edit window without cluttering the main view too much. The first use case is to add support for route redistribution to the UI in subsequent commits. Signed-off-by: Stefan Hanreich --- www/manager6/sdn/fabrics/FabricEdit.js | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js index 6111bbb51..43a402a99 100644 --- a/www/manager6/sdn/fabrics/FabricEdit.js +++ b/www/manager6/sdn/fabrics/FabricEdit.js @@ -37,6 +37,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { ], additionalItems: [], + additionalTabs: [], initComponent: function () { let me = this; @@ -97,7 +98,26 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { ); } - me.items.push(...me.additionalItems); + if (me.additionalTabs.length > 0) { + let items = [...me.items, ...me.additionalItems]; + + let iPanel = Ext.create('Proxmox.panel.InputPanel', { + title: gettext('Fabric'), + items, + }); + + me.bodyPadding = 0; + + me.items = [ + { + xtype: 'tabpanel', + bodyPadding: 10, + items: [iPanel, ...me.additionalTabs], + }, + ]; + } else { + me.items.push(...me.additionalItems); + } me.callParent(); }, -- 2.47.3