From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A86141FF133 for ; Mon, 27 Apr 2026 13:23:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8AF75197D2; Mon, 27 Apr 2026 13:23:35 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 3/3] qm: unlock: add reminder to switch to remove_lock() helper for a major release Date: Mon, 27 Apr 2026 13:22:45 +0200 Message-ID: <20260427112255.369695-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260427112255.369695-1-f.ebner@proxmox.com> References: <20260427112255.369695-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777288887214 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DG4LQZME5H6TJMOP2A6ZLM7FMIIIOEPL X-Message-ID-Hash: DG4LQZME5H6TJMOP2A6ZLM7FMIIIOEPL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For containers, the remove_lock() helper from the AbstractConfig module is already used. That method dies if no lock was found, while the current implementation for 'qm unlock' returns success. To avoid tripping up tooling, delay aligning the behavior between 'qm' and 'pct' to a future major release. Signed-off-by: Fiona Ebner --- src/PVE/CLI/qm.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index e64449d7..bc8a086c 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -391,6 +391,9 @@ __PACKAGE__->register_method({ my $vmid = $param->{vmid}; + # FIXME: MAJOR VERSION: switch to PVE::QemuConfig->remove_lock() to align behavior with + # containers. Note that remove_lock() will die when no lock is found, so that is a change in + # behavior. PVE::QemuConfig->lock_config( $vmid, sub { -- 2.47.3