From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7F4751FF140 for ; Fri, 24 Apr 2026 10:31:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5497E913; Fri, 24 Apr 2026 10:30:24 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v2 7/9] plugin: add get_identity method Date: Fri, 24 Apr 2026 10:29:41 +0200 Message-ID: <20260424082943.89614-8-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260424082943.89614-1-l.wagner@proxmox.com> References: <20260424082943.89614-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777019298084 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ESOJPDKXLQN75MHTRRLCTITDJ2XA3A6A X-Message-ID-Hash: ESOJPDKXLQN75MHTRRLCTITDJ2XA3A6A X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This one should return a unique identifier for each distinct storage entity. Signed-off-by: Lukas Wagner --- src/PVE/Storage/PBSPlugin.pm | 9 +++++++++ src/PVE/Storage/Plugin.pm | 17 +++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 17e285a..b916fe4 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b/src/PVE/Storage/PBSPlugin.pm @@ -1002,4 +1002,13 @@ sub volume_has_feature { return undef; } +sub get_identity { + my ($class, $scfg, $storeid) = @_; + + my $client = PVE::PBSClient->new($scfg, $storeid); + my $ret = $client->get_server_identity(); + + return $ret->{'pbs-instance-id'}; +} + 1; diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index afd3141..691aad3 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2569,4 +2569,21 @@ sub config_aware_base_mkdir { } } +=pod + +=head3 get_identity + + $plugin->get_identity($scfg, $storeid) + +Return a unique identifier for this storage instance. The exact format and semantics +may vary based on the concrete plugin implementation. + +=cut + +sub get_identity { + my ($class, $scfg, $storeid) = @_; + + die("get_identity not implemented for this plugin"); +} + 1; -- 2.47.3