From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8F73E1FF13F for ; Thu, 23 Apr 2026 16:02:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9E8F1A86E; Thu, 23 Apr 2026 16:02:25 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v3 6/8] sdn: evpn: validate fabric has prefix at controller update time Date: Thu, 23 Apr 2026 16:02:12 +0200 Message-ID: <20260423140214.187001-7-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260423140214.187001-1-h.laimer@proxmox.com> References: <20260423140214.187001-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776952847222 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GIT2UZCK7QQHOBAY3FCFFJIH3TWGNF77 X-Message-ID-Hash: GIT2UZCK7QQHOBAY3FCFFJIH3TWGNF77 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: BGP fabrics can be created without an IP prefix. Without this check, an EVPN controller could reference such a fabric and only fail at config generation time. --- src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm index ac92ea8b..f9feb35b 100644 --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm @@ -634,6 +634,15 @@ sub on_update_hook { die "must have exactly one of peers / fabric defined" if ($controller->{peers} && $controller->{fabric}) || !($controller->{peers} || $controller->{fabric}); + + if ($controller->{fabric}) { + my $fabric_config = PVE::Network::SDN::Fabrics::config(1); + my $fabric = eval { $fabric_config->get_fabric($controller->{fabric}) }; + die "fabric '$controller->{fabric}' does not exist: $@" if $@; + die + "fabric '$controller->{fabric}' needs an IPv4 or IPv6 prefix to serve as an EVPN underlay" + if !$fabric->{ip_prefix} && !$fabric->{ip6_prefix}; + } } } -- 2.47.3