From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D73211FF13F for ; Thu, 23 Apr 2026 15:37:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 43E67192C5; Thu, 23 Apr 2026 15:36:50 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v5 7/8] fix #5076: api: support audiences property for open id realms Date: Thu, 23 Apr 2026 15:35:47 +0200 Message-ID: <20260423133548.349086-8-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260423133548.349086-1-s.sterz@proxmox.com> References: <20260423133548.349086-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776951264517 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.120 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UUOBCJ3IOVKGJBFA63UIMVT673K7FJFV X-Message-ID-Hash: UUOBCJ3IOVKGJBFA63UIMVT673K7FJFV X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: to allow for better compatability with open id providers, support the audiences field for open id realms. users can specify which audiences are trusted in addition to the client-id. Signed-off-by: Shannon Sterz --- src/api2/access/openid.rs | 8 ++++++++ src/api2/config/access/openid.rs | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/src/api2/access/openid.rs b/src/api2/access/openid.rs index cb94b0e18..818bcb555 100644 --- a/src/api2/access/openid.rs +++ b/src/api2/access/openid.rs @@ -50,6 +50,13 @@ fn openid_authenticator( ); } + let audiences = realm_config.audiences.as_ref().map(|list| { + list.split(|c: char| c == ',' || c == ';' || char::is_ascii_whitespace(&c)) + .filter(|s| !s.is_empty()) + .map(String::from) + .collect() + }); + let config = OpenIdConfig { issuer_url: realm_config.issuer_url.clone(), client_id: realm_config.client_id.clone(), @@ -57,6 +64,7 @@ fn openid_authenticator( prompt: realm_config.prompt.clone(), scopes: Some(scopes), acr_values, + audiences, }; OpenIdAuthenticator::discover(&config, redirect_url) } diff --git a/src/api2/config/access/openid.rs b/src/api2/config/access/openid.rs index ab05bfb68..b71e4dae6 100644 --- a/src/api2/config/access/openid.rs +++ b/src/api2/config/access/openid.rs @@ -159,6 +159,8 @@ pub enum DeletableProperty { Prompt, /// Delete the acr_values property AcrValues, + /// Delete the audiences property + Audiences, } #[api( @@ -231,6 +233,9 @@ pub fn update_openid_realm( DeletableProperty::AcrValues => { config.acr_values = None; } + DeletableProperty::Audiences => { + config.audiences = None; + } } } } @@ -273,6 +278,9 @@ pub fn update_openid_realm( if update.acr_values.is_some() { config.acr_values = update.acr_values; } + if update.audiences.is_some() { + config.audiences = update.audiences; + } domains.set_data(&realm, "openid", &config)?; -- 2.47.3