From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 697991FF13F for ; Thu, 23 Apr 2026 14:40:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABE4C16515; Thu, 23 Apr 2026 14:40:14 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server v2 0/7] fix #7383: agent: fsfreeze: skip freeze if already frozen Date: Thu, 23 Apr 2026 14:35:11 +0200 Message-ID: <20260423124004.115303-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776947918896 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuconfig.pm,qemuserver.pm,agent.pm,qmpclient.pm,blockjob.pm,qemu.pm] Message-ID-Hash: 67CWZV2QVJY3BPSLVCC3E6I2MUZST5F3 X-Message-ID-Hash: 67CWZV2QVJY3BPSLVCC3E6I2MUZST5F3 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v2: * Drop already applied patches. * Rebase on master, making use of the new should_fs_freeze() function. * Add patch to switch to v5.36 and use subroutine signatures. * Add patch renaming guest_fs{freeze,thaw} to guest_fs_{freeze,thaw}. * Drop patch for changing signature of get_qga_key(). * Rename guest_fsfreeze_applicable() to guest_fs_freeze_applicable(). * Simplify log function (usage) in guest_fsfreeze_applicable(). * Drop $is_backup argument from guest_fs_freeze_applicable() now that there is no backup-specific option anymore (is an alias for the general one). * Pass guest agent config for move disk caller of clone_disk() for completenetss. The first patch migrates the agent module to use v5.36 and subroutine signatures. The second patch renames guest_fs{freeze,thaw} to guest_fs_{freeze,thaw} for consistency with should_fs_freeze(). The next four patches lead up to harmonizing the checks for guest filesystem freeze which previously were duplicated to three different places and improve encapsulation of the agent module. The last patch closes bug #7383 and checks if the filesystem is already frozen before attempting freeze to avoid a confusing error message. qemu-server: Fiona Ebner (7): agent: migrate to v5.36 and use subroutine signatures agent: rename guest_fs{freeze,thaw} to guest_fs_{freeze,thaw} agent: parse: change signature to take property string rather than full VM config agent: should fs freeze: change signature to take property string rather than full VM config clone disk/block jobs: change signatures to take guest agent property string agent: fs freeze: harmonize checks for guest fs freeze fix #7383: agent: fsfreeze: skip freeze if already frozen src/PVE/API2/Qemu.pm | 10 +-- src/PVE/QMPClient.pm | 2 +- src/PVE/QemuConfig.pm | 18 +++-- src/PVE/QemuServer.pm | 8 +-- src/PVE/QemuServer/Agent.pm | 121 +++++++++++++++++++++------------ src/PVE/QemuServer/BlockJob.pm | 19 ++---- src/PVE/VZDump/QemuServer.pm | 24 +++---- 7 files changed, 109 insertions(+), 93 deletions(-) Summary over all repositories: 7 files changed, 109 insertions(+), 93 deletions(-) -- Generated by git-murpp 0.5.0