From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E9C341FF13F for ; Thu, 23 Apr 2026 11:46:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C755D10636; Thu, 23 Apr 2026 11:46:53 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v2 0/3] Improve mkpath Error Message in activate_storage Date: Thu, 23 Apr 2026 11:46:13 +0200 Message-ID: <20260423094619.205988-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776937490567 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,plugin.pm] Message-ID-Hash: RUMHCDM7CVU3YLGDNK4KLBN4WY73TITP X-Message-ID-Hash: RUMHCDM7CVU3YLGDNK4KLBN4WY73TITP X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: See the cover letter of v1 (linked below) for a description of this series. Changes since v1: - Rebased on master (nothing changed) - Clarified message of patch #2, as pointed out by Fiona [1] (thanks!) - Improved the error matching done in patch #3 as suggested by Fabian [2] (thanks!) and updated the commit message accordingly Older Versions ============== v1: https://lore.proxmox.com/pve-devel/20251205154404.446338-1-m.carrara@proxmox.com/ References ========== [1]: https://lore.proxmox.com/pve-devel/60139202-64a0-4111-9773-a571ffde0389@proxmox.com/ [2]: https://lore.proxmox.com/pve-devel/1768487461.gbidzul2yw.astroid@yuna.none/ Summary of Changes ================== Max R. Carrara (3): plugin: use guard clause to reduce nesting plugin: remove needless inequality check when creating content subdirs plugin: improve error handling when creating a content subdir fails src/PVE/Storage/Plugin.pm | 80 ++++++++++++++++++++++++++------------- 1 file changed, 54 insertions(+), 26 deletions(-) -- 2.47.3