From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E6CC91FF13F for ; Thu, 23 Apr 2026 11:39:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 46EECF0D1; Thu, 23 Apr 2026 11:38:34 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v3 02/18] qmp client: add default timeouts for more block commands Date: Thu, 23 Apr 2026 11:35:56 +0200 Message-ID: <20260423093753.43199-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260423093753.43199-1-f.ebner@proxmox.com> References: <20260423093753.43199-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776936990520 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmpclient.pm] Message-ID-Hash: KWRP7233KI6FFXQ76HSELO2C5SY6ARAV X-Message-ID-Hash: KWRP7233KI6FFXQ76HSELO2C5SY6ARAV X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Based on pre-existing defaults for similar commands, commands for adding get 1 minute, commands for creating block jobs or removing get 10 minutes, since those might require in-flight IO to finish. Signed-off-by: Fiona Ebner --- src/PVE/QMPClient.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm index 723123a6..4d4a2f82 100644 --- a/src/PVE/QMPClient.pm +++ b/src/PVE/QMPClient.pm @@ -120,6 +120,8 @@ sub cmd { $timeout = 3 * 60; } elsif ( $cmd->{execute} eq 'blockdev-add' + || $cmd->{execute} eq 'blockdev-insert-medium' + || $cmd->{execute} eq 'block-export-add' || $cmd->{execute} eq 'device_add' || $cmd->{execute} eq 'device_del' || $cmd->{execute} eq 'netdev_add' @@ -130,8 +132,13 @@ sub cmd { $timeout = 60; } elsif ( $cmd->{execute} eq 'backup-cancel' + || $cmd->{execute} eq 'block-commit' + || $cmd->{execute} eq 'block-export-del' + || $cmd->{execute} eq 'block-stream' || $cmd->{execute} eq 'blockdev-del' || $cmd->{execute} eq 'blockdev-mirror' + || $cmd->{execute} eq 'blockdev-remove-medium' + || $cmd->{execute} eq 'blockdev-reopen' || $cmd->{execute} eq 'block-job-cancel' || $cmd->{execute} eq 'job-complete' || $cmd->{execute} eq 'drive-mirror' -- 2.47.3