From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 610231FF13B for ; Wed, 22 Apr 2026 13:17:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 392D318CAF; Wed, 22 Apr 2026 13:14:45 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v1 41/54] test: parse volname: adapt tests regarding 'import' volume type Date: Wed, 22 Apr 2026 13:13:07 +0200 Message-ID: <20260422111322.257380-42-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260422111322.257380-1-m.carrara@proxmox.com> References: <20260422111322.257380-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776856359708 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5IPDUMED6CBRTBK55RH3HLRCUDIFFTBG X-Message-ID-Hash: 5IPDUMED6CBRTBK55RH3HLRCUDIFFTBG X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Give the existing test cases unique 'description' keys and also reorder them. Add additional test cases for qcow2, vmdk and raw files. Signed-off-by: Max R. Carrara --- src/test/parse_volname_test.pm | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/src/test/parse_volname_test.pm b/src/test/parse_volname_test.pm index a03ac163..ea07c56b 100644 --- a/src/test/parse_volname_test.pm +++ b/src/test/parse_volname_test.pm @@ -146,27 +146,42 @@ my $tests = [ expected => ['import', 'import.ovf', undef, undef, undef, undef, 'ovf'], }, { - description => "Import, inner file of ova", + description => "Import, qcow2", + volname => 'import/import.qcow2', + expected => ['import', 'import.qcow2', undef, undef, undef, undef, 'qcow2'], + }, + { + description => "Import, vmdk", + volname => 'import/import.vmdk', + expected => ['import', 'import.vmdk', undef, undef, undef, undef, 'vmdk'], + }, + { + description => "Import, raw", + volname => 'import/import.raw', + expected => ['import', 'import.raw', undef, undef, undef, undef, 'raw'], + }, + { + description => "Import, inner file of ova (qcow2)", volname => 'import/import.ova/disk.qcow2', expected => ['import', 'import.ova/disk.qcow2', undef, undef, undef, undef, 'ova+qcow2'], }, { - description => "Import, inner file of ova", + description => "Import, inner file of ova (vmdk)", volname => 'import/import.ova/disk.vmdk', expected => ['import', 'import.ova/disk.vmdk', undef, undef, undef, undef, 'ova+vmdk'], }, + { + description => "Import, inner file of ova (raw)", + volname => 'import/import.ova/disk.raw', + expected => ['import', 'import.ova/disk.raw', undef, undef, undef, undef, 'ova+raw'], + }, { description => "Import, inner file of ova with whitespace in name", volname => 'import/import.ova/OS disk.vmdk', expected => ['import', 'import.ova/OS disk.vmdk', undef, undef, undef, undef, 'ova+vmdk'], }, - { - description => "Import, inner file of ova", - volname => 'import/import.ova/disk.raw', - expected => ['import', 'import.ova/disk.raw', undef, undef, undef, undef, 'ova+raw'], - }, # # failed matches # -- 2.47.3