From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A83DC1FF13B for ; Wed, 22 Apr 2026 13:19:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6666719B87; Wed, 22 Apr 2026 13:15:03 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v1 35/54] test: list volumes: fix broken test checking for vmlist modifications Date: Wed, 22 Apr 2026 13:13:01 +0200 Message-ID: <20260422111322.257380-36-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260422111322.257380-1-m.carrara@proxmox.com> References: <20260422111322.257380-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776856353088 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4A3JYHAILVXLV3JCQSUNN6V6N2BTBHRL X-Message-ID-Hash: 4A3JYHAILVXLV3JCQSUNN6V6N2BTBHRL X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This test never actually did anything, since it didn't use the mocked vmlist at all. Therefore, fix it by comparing the vmlist with its original after all tests have run. Verified that this test catches modifications to the vmlist by manually adding a line that modifies it in the `list_volumes()` method, running the tests to see if this fails, and then removing that line again. Signed-off-by: Max R. Carrara --- src/test/list_volumes_test.pm | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm index 053ebbe3..2d941b60 100644 --- a/src/test/list_volumes_test.pm +++ b/src/test/list_volumes_test.pm @@ -719,26 +719,19 @@ sub main() { my $plan = scalar @tests; plan tests => $plan + 1; - { - # don't accidentally modify vmlist, see bug report - # https://pve.proxmox.com/pipermail/pve-devel/2020-January/041096.html - my $scfg_with_type = { path => $storage_dir, type => 'dir' }; - my $original_vmlist = { ids => {} }; - my $tested_vmlist = dclone($original_vmlist); - - PVE::Storage::Plugin->list_volumes('sid', $scfg_with_type, undef, ['images']); - - is_deeply($tested_vmlist, $original_vmlist, 'PVE::Cluster::vmlist remains unmodified') - || diag( - "Expected vmlist to remain\n", - explain($original_vmlist), - "but it turned to\n", - explain($tested_vmlist), - ); - } + # Keep the original vmlist around in order to check whether it was modified + # after running all the tests. See: + # https://pve.proxmox.com/pipermail/pve-devel/2020-January/041096.html + my $original_vmlist = dclone(PVE::Cluster::get_vmlist()); run_legacy_tests(); + my $vmlist = PVE::Cluster::get_vmlist(); + + is_deeply( + $vmlist, $original_vmlist, 'Result of PVE::Cluster::get_vmlist remains unmodified', + ); + done_testing(); return; -- 2.47.3