From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0D7DF1FF13B for ; Wed, 22 Apr 2026 13:14:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4AC3116F5E; Wed, 22 Apr 2026 13:14:10 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v1 02/54] plugin, common: remove superfluous use of =pod command paragraph Date: Wed, 22 Apr 2026 13:12:28 +0200 Message-ID: <20260422111322.257380-3-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260422111322.257380-1-m.carrara@proxmox.com> References: <20260422111322.257380-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776856316946 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 64Q7WQ7WW32OPRRWU5CJMADCTMDXPM6W X-Message-ID-Hash: 64Q7WQ7WW32OPRRWU5CJMADCTMDXPM6W X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Because a POD block may be started using any POD command paragraph [0], using =pod here is not necessary. Therefore, remove these occurrences. In other words, =head1 and =head3 (for example) already begin a POD block, so explicitly opening one with =pod is not needed. This has the benefit of making the docstrings take up a little less space overall. [0]: https://perldoc.perl.org/perlpodspec#Pod-Commands Signed-off-by: Max R. Carrara --- src/PVE/Storage/Common.pm | 18 ------------------ src/PVE/Storage/Plugin.pm | 6 ------ 2 files changed, 24 deletions(-) diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm index 3932aeeb..c5f69694 100644 --- a/src/PVE/Storage/Common.pm +++ b/src/PVE/Storage/Common.pm @@ -11,8 +11,6 @@ use constant { FALLOC_FL_PUNCH_HOLE => 0x02, # see linux/falloc.h }; -=pod - =head1 NAME PVE::Storage::Common - Shared functions and utilities for storage plugins and storage operations @@ -74,14 +72,10 @@ PVE::JSONSchema::register_standard_option( }, ); -=pod - =head1 FUNCTIONS =cut -=pod - =head3 align_size_up $aligned_size = align_size_up($size, $granularity) @@ -102,8 +96,6 @@ sub align_size_up : prototype($$) { return $aligned_size; } -=pod - =head3 deallocate deallocate($file_handle, $offset, $length) @@ -147,8 +139,6 @@ my sub run_qemu_img_json { return $json; } -=pod - =head3 qemu_img_create qemu_img_create($fmt, $size, $path, $options) @@ -172,8 +162,6 @@ sub qemu_img_create { run_command($cmd, errmsg => "unable to create image"); } -=pod - =head3 qemu_img_create_qcow2_backed qemu_img_create_qcow2_backed($path, $backing_path, $backing_format, $options) @@ -209,8 +197,6 @@ sub qemu_img_create_qcow2_backed { run_command($cmd, errmsg => "unable to create image"); } -=pod - =head3 qemu_img_info qemu_img_info($filename, $file_format, $timeout, $follow_backing_files) @@ -231,8 +217,6 @@ sub qemu_img_info { return run_qemu_img_json($cmd, $timeout); } -=pod - =head3 qemu_img_measure qemu_img_measure($size, $fmt, $timeout, $options) @@ -255,8 +239,6 @@ sub qemu_img_measure { return run_qemu_img_json($cmd, $timeout); } -=pod - =head3 qemu_img_resize qemu_img_resize($path, $format, $size, $preallocation, $timeout) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index afd31414..84ac412a 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2311,8 +2311,6 @@ sub rename_volume { return "${storeid}:${base}${target_vmid}/${target_volname}"; } -=pod - =head3 rename_snapshot $plugin->rename_snapshot($scfg, $storeid, $volname, $source_snap, $target_snap) @@ -2362,8 +2360,6 @@ my sub blockdev_options_nbd_unix { return $blockdev; } -=pod - =head3 qemu_blockdev_options $blockdev = @@ -2535,8 +2531,6 @@ sub new_backup_provider { die "implement me if enabling the feature 'backup-provider' in plugindata()->{features}\n"; } -=pod - =head3 volume_qemu_snapshot_method $method = $plugin->volume_qemu_snapshot_method($storeid, $scfg, $volname); -- 2.47.3