From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C79351FF13B for ; Wed, 22 Apr 2026 13:18:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 60A2319168; Wed, 22 Apr 2026 13:14:48 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v1 18/54] api: status: use helper from common module to get content directory Date: Wed, 22 Apr 2026 13:12:44 +0200 Message-ID: <20260422111322.257380-19-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260422111322.257380-1-m.carrara@proxmox.com> References: <20260422111322.257380-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776856334446 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E32LWS7M5DE5EVXGWA4EK7QQ2KESH6KT X-Message-ID-Hash: E32LWS7M5DE5EVXGWA4EK7QQ2KESH6KT X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In the subroutines for the upload / download_url API methods, use the `plugin_get_vtype_subdir()` helper from `PVE::Storage::Common` to obtain the sub-directory for the provided content type (vtype), instead of doing that within the if-elsif chains. Signed-off-by: Max R. Carrara --- src/PVE/API2/Storage/Status.pm | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index b9e949ff..742596d4 100644 --- a/src/PVE/API2/Storage/Status.pm +++ b/src/PVE/API2/Storage/Status.pm @@ -20,6 +20,9 @@ use PVE::API2::Storage::Content; use PVE::API2::Storage::FileRestore; use PVE::API2::Storage::PruneBackups; use PVE::Storage; +use PVE::Storage::Common qw( + plugin_get_vtype_subdir +); use base qw(PVE::RESTHandler); @@ -608,7 +611,6 @@ __PACKAGE__->register_method({ my $filename = PVE::Storage::normalize_content_filename($param->{filename}); - my $path; my $is_ova = 0; my $image_format; @@ -616,12 +618,10 @@ __PACKAGE__->register_method({ if ($filename !~ m![^/]+$PVE::Storage::ISO_EXT_RE_0$!) { raise_param_exc({ filename => "wrong file extension" }); } - $path = PVE::Storage::get_iso_dir($cfg, $storage); } elsif ($content eq 'vztmpl') { if ($filename !~ m![^/]+$PVE::Storage::VZTMPL_EXT_RE_1$!) { raise_param_exc({ filename => "wrong file extension" }); } - $path = PVE::Storage::get_vztmpl_dir($cfg, $storage); } elsif ($content eq 'import') { if ($filename !~ m!${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::UPLOAD_IMPORT_EXT_RE_1$! @@ -635,10 +635,10 @@ __PACKAGE__->register_method({ } else { $image_format = $format; } - - $path = PVE::Storage::get_import_dir($cfg, $storage); } + my $path = plugin_get_vtype_subdir($scfg, $content); + my $dest = "$path/$filename"; my $dirname = dirname($dest); @@ -840,7 +840,6 @@ __PACKAGE__->register_method({ my $filename = PVE::Storage::normalize_content_filename($param->{filename}); - my $path; my $is_ova = 0; my $image_format; @@ -848,12 +847,10 @@ __PACKAGE__->register_method({ if ($filename !~ m![^/]+$PVE::Storage::ISO_EXT_RE_0$!) { raise_param_exc({ filename => "wrong file extension" }); } - $path = PVE::Storage::get_iso_dir($cfg, $storage); } elsif ($content eq 'vztmpl') { if ($filename !~ m![^/]+$PVE::Storage::VZTMPL_EXT_RE_1$!) { raise_param_exc({ filename => "wrong file extension" }); } - $path = PVE::Storage::get_vztmpl_dir($cfg, $storage); } elsif ($content eq 'import') { if ($filename !~ m!${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::UPLOAD_IMPORT_EXT_RE_1$! @@ -867,10 +864,10 @@ __PACKAGE__->register_method({ } else { $image_format = $format; } - - $path = PVE::Storage::get_import_dir($cfg, $storage); } + my $path = plugin_get_vtype_subdir($scfg, $content); + PVE::Storage::activate_storage($cfg, $storage); File::Path::make_path($path); -- 2.47.3