From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 40C911FF136 for ; Mon, 20 Apr 2026 18:44:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAF9BB318; Mon, 20 Apr 2026 18:43:58 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v2 4/8] add functions to determine warning level for high token timeouts Date: Mon, 20 Apr 2026 18:43:10 +0200 Message-ID: <20260420164314.370023-5-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260420164314.370023-1-m.koeppl@proxmox.com> References: <20260420164314.370023-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776703315401 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CED4V4KVXJSFLAWIJYTYLQRWJJOQTI4I X-Message-ID-Hash: CED4V4KVXJSFLAWIJYTYLQRWJJOQTI4I X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: High token timeouts can lead to stability problems in clusters. To inform users about the timeout in their current setup (or expected timeouts when adding nodes) and give recommendations regarding the token coefficient setting, introduce function to calculate the timeout as well as determine the warning / recommendation levels. Signed-off-by: Michael Köppl --- src/PVE/Corosync.pm | 50 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/PVE/Corosync.pm b/src/PVE/Corosync.pm index aef0d31..6391e3c 100644 --- a/src/PVE/Corosync.pm +++ b/src/PVE/Corosync.pm @@ -534,4 +534,54 @@ sub resolve_hostname_like_corosync { return $match_ip_and_version->($resolved_ip); } +sub calculate_membership_recovery_timeout { + my ($totemcfg, $node_count) = @_; + + my $token_timeout = $totemcfg->{token} // 3000; + my $token_coefficient = $totemcfg->{token_coefficient} // 650; + + my $expected_token_timeout = $token_timeout; + if ($node_count > 2) { + $expected_token_timeout += ($node_count - 2) * $token_coefficient; + } + + my $expected_consensus_timeout = $totemcfg->{consensus} // $expected_token_timeout * 1.2; + return ($expected_token_timeout + $expected_consensus_timeout) / 1000.0; +} + +sub get_timeout_warning_level { + my ($total_timeout_secs) = @_; + + if ($total_timeout_secs > 45) { + return 'change-strongly-recommended'; + } elsif ($total_timeout_secs > 40) { + return 'change-recommended'; + } elsif ($total_timeout_secs > 30) { + return 'optimize'; + } + + return undef; +} + +sub get_timeout_warning { + my ($total_timeout_secs) = @_; + + my $level = get_timeout_warning_level($total_timeout_secs); + return undef if !defined($level); + + my $level_msg; + if ($level eq 'change-strongly-recommended') { + $level_msg = "Changing the token coefficient is strongly recommended"; + } elsif ($level eq 'change-recommended') { + $level_msg = "Changing the token coefficient is recommended"; + } elsif ($level eq 'optimize') { + $level_msg = "Token coefficient can be optimized"; + } + + return + "Sum of Corosync token and consensus timeout is ${total_timeout_secs}s. " + . "$level_msg. " + . "See https://pve.proxmox.com/pve-docs/chapter-pvecm.html#_changing_the_token_coefficient for details."; +} + 1; -- 2.47.3