From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8FE171FF136 for ; Mon, 20 Apr 2026 18:43:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7583FAC08; Mon, 20 Apr 2026 18:43:25 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters Date: Mon, 20 Apr 2026 18:43:06 +0200 Message-ID: <20260420164314.370023-1-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776703315084 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.101 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7Z3ZGHS2NNYP5QQUV4BT57UKPNOKR43L X-Message-ID-Hash: 7Z3ZGHS2NNYP5QQUV4BT57UKPNOKR43L X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series introduces warnings informing users about high token timeouts in their clusters. A recent change [0] lowered the token coefficient for clusters and allowed adapting it. However, this change only affects new clusters. As described in [1], users with existing cluster should be informed about the high token timeouts in their configurations and what they can do to alleviate this problem. Thus, warnings are added to the `pvecm status` command as well as to the cluster join info dialog in the web UI. The warning in the web UI warns users about the effect adding another node would have to allow them to make an informed change before adding another node. changes since v1 (thanks to @Friedrich for the feedback on v1): - add pve-docs patch to allow using get_help_link to directly link to an anchor in the local documentation (then used to link to the section on changing the token coefficient) - add pve-docs patch to define explicit anchor for the "Changing the Token Coefficient" section - add pve-docs patch extending the section for Changing the Token Coefficient slightly, informing users of the potential warning messages in the pvecm status output - change the threshold for "strongly recommend" from 50s to 45s as suggested by @Friedrich - adapted the name of calculate_total_timeout to calculate_membership_recovery_timeout - adapted commit messages for preparatory pve-manager patch (no functional changes intended) - moved the warning message in pvecm from `pvecm nodes` to `pvecm status` - replaced the URL in the pvecm warning message with a reference to the pvecm man pages - link to local documentation in ClusterEdit.js [0] https://git.proxmox.com/?p=pve-cluster.git;a=commit;h=a7b1c765b9223a81fb2dc4f072d6a6c095583cda [1] https://bugzilla.proxmox.com/show_bug.cgi?id=7398 pve-docs: Michael Köppl (3): asciidoc-pve: allow linking sections with get_help_link pvecm: add explicit anchor for token coefficient section pvecm: add info about warnings regarding token coefficient pvecm.adoc | 6 ++++++ scripts/asciidoc-pve.in | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) pve-cluster: Michael Köppl (3): add functions to determine warning level for high token timeouts pvecm: warn users of high token timeouts when using status command api: add token timeout and warning level to cluster join info src/PVE/API2/ClusterConfig.pm | 22 +++++++++++++++ src/PVE/CLI/pvecm.pm | 9 +++++++ src/PVE/Corosync.pm | 50 +++++++++++++++++++++++++++++++++++ 3 files changed, 81 insertions(+) pve-manager: Michael Köppl (2): ui: cluster info: move initialization of items to initComponent ui: cluster info: warn users of high token timeout in join info www/manager6/dc/Cluster.js | 4 + www/manager6/dc/ClusterEdit.js | 141 ++++++++++++++++++++++----------- 2 files changed, 97 insertions(+), 48 deletions(-) Summary over all repositories: 7 files changed, 185 insertions(+), 49 deletions(-) -- Generated by murpp 0.11.0