From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9700D1FF13E for ; Fri, 17 Apr 2026 14:27:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B6FF590; Fri, 17 Apr 2026 14:27:40 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 1/7] sim: always limit the priority level to 4 characters Date: Fri, 17 Apr 2026 14:27:16 +0200 Message-ID: <20260417122728.330123-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417122728.330123-1-d.kral@proxmox.com> References: <20260417122728.330123-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428771488 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: O44TVQEZ3OGW4N4F5UQDGQ7VN57A4UAJ X-Message-ID-Hash: O44TVQEZ3OGW4N4F5UQDGQ7VN57A4UAJ X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is already done in the PVE::HA::Sim::TestEnv::log(), do the same for the other Sim Env/Hardware implementations as any longer priority level (such as 'warning') would produce a log line, where the priority level would misalign the following time, log id and message columns. Signed-off-by: Daniel Kral --- src/PVE/HA/Sim/Env.pm | 1 + src/PVE/HA/Sim/Hardware.pm | 1 + src/PVE/HA/Sim/RTEnv.pm | 1 + src/PVE/HA/Sim/RTHardware.pm | 1 + src/PVE/HA/Sim/TestHardware.pm | 1 + 5 files changed, 5 insertions(+) diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm index 65d4efad..63368117 100644 --- a/src/PVE/HA/Sim/Env.pm +++ b/src/PVE/HA/Sim/Env.pm @@ -332,6 +332,7 @@ sub log { chomp $msg; my $time = $self->get_time(); + $level = substr($level, 0, 4); printf("%-5s %5d %12s: $msg\n", $level, $time, "$self->{nodename}/$self->{log_id}"); } diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 82f85c97..163e35af 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -669,6 +669,7 @@ sub log { chomp $msg; my $time = $self->get_time(); + $level = substr($level, 0, 4); $id = 'hardware' if !$id; diff --git a/src/PVE/HA/Sim/RTEnv.pm b/src/PVE/HA/Sim/RTEnv.pm index ab5ac996..50d0731e 100644 --- a/src/PVE/HA/Sim/RTEnv.pm +++ b/src/PVE/HA/Sim/RTEnv.pm @@ -31,6 +31,7 @@ sub log { my ($self, $level, $msg) = @_; chomp $msg; + $level = substr($level, 0, 4); my $time = $self->get_time(); diff --git a/src/PVE/HA/Sim/RTHardware.pm b/src/PVE/HA/Sim/RTHardware.pm index 9528f542..d16582a3 100644 --- a/src/PVE/HA/Sim/RTHardware.pm +++ b/src/PVE/HA/Sim/RTHardware.pm @@ -65,6 +65,7 @@ sub log { chomp $msg; my $time = $self->get_time(); + $level = substr($level, 0, 4); $id = 'hardware' if !$id; diff --git a/src/PVE/HA/Sim/TestHardware.pm b/src/PVE/HA/Sim/TestHardware.pm index ebe6b546..0cedce7b 100644 --- a/src/PVE/HA/Sim/TestHardware.pm +++ b/src/PVE/HA/Sim/TestHardware.pm @@ -68,6 +68,7 @@ sub log { chomp $msg; my $time = $self->get_time(); + $level = substr($level, 0, 4); $id = 'hardware' if !$id; -- 2.47.3