From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 221451FF13E for ; Fri, 17 Apr 2026 14:27:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D61436CC; Fri, 17 Apr 2026 14:27:41 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 0/7] some test logging output improvements Date: Fri, 17 Apr 2026 14:27:15 +0200 Message-ID: <20260417122728.330123-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428771390 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EKW2MPOYUPNVEL7OKHXRGHO4MW3IWNKU X-Message-ID-Hash: EKW2MPOYUPNVEL7OKHXRGHO4MW3IWNKU X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series makes some improvements on how tests output their logs, especially to make any unexpected warnings fail the test cases. This catches the typical 'uninitialized variable used' and other Perl warnings, which would have gone unnoticed beforehand as there's much more output on STDOUT than STDERR. This is a small QoL improvement when working on the HA stack because it catches newly introduced perl warnings early and a git rebase master --exec 'make clean && make deb' with enough test branch coverage should give at least some confidence that the individual patches are ordered correctly and do not introduce Perl warnings. Also a small patch at the end I've used locally for some time to better highlight the diff output for failed test cases. Daniel Kral (7): sim: always limit the priority level to 4 characters consistently use correct priority levels for log calls sim: hardware: factor common service lock hash access in unlock_service use log with warning priority instead of warn where possible pve-ha-tester: capture and fail for unexpected perl warnings test: ha-tester: use consistent word casing for failed test messages test: ha-tester: use colorized diff for unexpected test log outputs src/PVE/HA/Env.pm | 2 ++ src/PVE/HA/Env/PVE2.pm | 4 ++-- src/PVE/HA/Fence.pm | 2 +- src/PVE/HA/Manager.pm | 6 +++--- src/PVE/HA/Resources/PVEVM.pm | 2 +- src/PVE/HA/Sim/Env.pm | 2 ++ src/PVE/HA/Sim/Hardware.pm | 17 ++++++++++------- src/PVE/HA/Sim/RTEnv.pm | 1 + src/PVE/HA/Sim/RTHardware.pm | 1 + src/PVE/HA/Sim/Resources/VirtCT.pm | 2 +- src/PVE/HA/Sim/TestHardware.pm | 1 + src/pve-ha-tester | 8 ++++++++ src/test/ha-tester.pl | 6 +++--- src/test/test-locked-service2/log.expect | 9 +++++++++ 14 files changed, 45 insertions(+), 18 deletions(-) -- 2.47.3