From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2569D1FF13A for ; Wed, 15 Apr 2026 13:59:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 99ACB11C8B; Wed, 15 Apr 2026 13:59:06 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Subject: [PATCH common/proxmox{,-backup}/storage 0/7] establish unique instance-id for PBS nodes Date: Wed, 15 Apr 2026 13:58:10 +0200 Message-ID: <20260415115817.348947-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776254226416 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.096 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DTLUWZXQPUDK3QVSAU27K33LNXNVY2S5 X-Message-ID-Hash: DTLUWZXQPUDK3QVSAU27K33LNXNVY2S5 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In PDM we require some way to match PBS storage <-> PBS remote. Having some kind of unique ID for each PBS instance should make it quite easy to establish such a mapping completely automatically. The general approach is 1.) add /nodes/localhost/server-identity route in PBS, returning a unique, per-installation ID 2.) add something like /nodes/.../storage//identity in PVE, which uses proxmox-backup-client internally to return the instance ID for this PBS storage 3.) PDM can then use both API routes to establish the mapping Significant changes since the RFC: - fixup copy-paste doc mistakes (thx @ Shannon) - in PVE, the API is now '/nodes//storage//identity', as this is hopefully generic enough that it could be used for other storages enough. - in PBS, the API is now at /nodes/localhost/server-identity - in the Perl PBSClient, the method to retrieve the identity is now "get_server_identity" proxmox: Fabian Grünbichler (1): systemd: add support for machine-id generation Lukas Wagner (1): pbs-api-types: add ServerIdentity response type pbs-api-types/src/node.rs | 9 +++++ proxmox-systemd/src/lib.rs | 2 + proxmox-systemd/src/sd_id128.rs | 70 +++++++++++++++++++++++++++++++++ proxmox-systemd/src/sys.rs | 6 +++ 4 files changed, 87 insertions(+) create mode 100644 proxmox-systemd/src/sd_id128.rs proxmox-backup: Lukas Wagner (3): api: add /nodes/localhost/server-identity client: add 'server-identity' sub-command manager: add 'server-identity' subcommand proxmox-backup-client/src/main.rs | 44 ++++++++++++++++++++++++-- src/api2/node/mod.rs | 40 ++++++++++++++++++++++- src/bin/proxmox_backup_manager/node.rs | 30 ++++++++++++++++++ 3 files changed, 110 insertions(+), 4 deletions(-) pve-common: Lukas Wagner (1): pbs-client: add support for the 'server-identity' command src/PVE/PBSClient.pm | 7 +++++++ 1 file changed, 7 insertions(+) pve-storage: Lukas Wagner (1): api: add /nodes//storage//identity route src/PVE/API2/Storage/Status.pm | 48 +++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-) Summary over all repositories: 9 files changed, 251 insertions(+), 5 deletions(-) -- Generated by murpp 0.12.0