Re: [PATCH cluster/ha-manager/manager v4 00/28] dynamic scheduler + load rebalancer

Dominik Rusovac
2026-04-02T14:24:13Z

Reviewed all of the patches from v1 up to v4. Tested the behavior
of the CRS in a 3-node-cluster and in a 7-node-cluster regarding:
* disarmed HA and re-armed HA
* maintenance mode of nodes
* fenced nodes
* affinity rules

Moreover:
* used all of the variations (static or dynamic with bruteforce or
topsis)
* played around with a bunch of different thresholds, margins and hold
durations for the purpose of fine tuning the scheduler
* verified that hostnames can include hyphens, for example
* verified that minimum requirements for number fields are detected
* used UI for setting different auto-rebalance parameters

Observations:
* scoring of best migration cannot happen in the same round as enabling
maintenance mode, obtained warning:

"unable to score best balancing migration - leader 'ct:205' is not present in the cluster usage"

* sustained imbalance round counter is not reset in case of early
returns, which, e.g., can cause auto rebalance immediately after
re-arming or disabling maintenance mode

Looks good to me overall, I think the tiny things related to my
observations could be fixed in a small follow-up.

On Thu Apr 2, 2026 at 2:43 PM CEST, Daniel Kral wrote:
> Here's the v4 of the load balancer patches for the HA Manager.
>
> Most of the patches here are already R-b'd by @Dominik (many, many
> thanks!) and only a few things have changed, the biggest of course is
> changing the default node imbalance threshold from '0.7' to '0.3' and
> adding the pve-manager patches.
>
> I'm already half-way there with the pve-docs patches, but will send them
> in a separate patch series (as the changes are also updating the CRS
> section in general).
>
> Thank you very much for the feedback @Dominik, @Thomas, @Maximiliano,
> and @Jillian Morgan!
>

[snip]

Consider this as:

Tested-by: Dominik Rusovac <d.rusovac@proxmox.com>