Re: [PATCH manager v4 28/28] ui: form: add crs auto rebalancing options

Dominik Rusovac
2026-04-02T13:38:24Z

lgtm, consider this

On Thu Apr 2, 2026 at 2:44 PM CEST, Daniel Kral wrote:
> ha-auto-rebalance-{method,margin,hold-duration,margin} require
> ha-auto-rebalance to be enabled in the schema, therefore they are
> disabled here unless ha-auto-rebalance is enabled.

good measure

>
> The label width was enlared a bit, so that the longer labels for the
> auto rebalancing options are more readable.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v3 -> v4:
> - new!
> - only changes from v1 are that a separate component is used now, it
> uses a viewModel to disable fields that shouldn't be set, and widen
> the label width a bit;
> - also 'Margin' is 'Minimum Imbalance Improvement' in the UI

+1, is more comprehensible imo

>
> www/manager6/form/CRSOptions.js | 62 ++++++++++++++++++++++++++++++++-
> 1 file changed, 61 insertions(+), 1 deletion(-)
>

[snip]