From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 763711FF13C for ; Thu, 02 Apr 2026 14:48:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A71A1636B; Thu, 2 Apr 2026 14:48:29 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v4 05/28] sim: hardware: pass correct types for static stats Date: Thu, 2 Apr 2026 14:43:59 +0200 Message-ID: <20260402124817.416232-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402124817.416232-1-d.kral@proxmox.com> References: <20260402124817.416232-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775134042840 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UR45HFHHJPCU7P5TEI2IG742MZWYGXVW X-Message-ID-Hash: UR45HFHHJPCU7P5TEI2IG742MZWYGXVW X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dominik Rusovac CRM expects f64 for cpu-related values and usize for mem-related values. Hence, pass doubles for the former and ints for the latter. Signed-off-by: Dominik Rusovac Signed-off-by: Daniel Kral --- changes v3 -> v4: - none src/PVE/HA/Sim/Hardware.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 474cee16..cfcd7ab1 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -488,9 +488,9 @@ sub new { || die "Copy failed: $!\n"; } else { my $cstatus = { - node1 => { power => 'off', network => 'off', maxcpu => 24, maxmem => 131072 }, - node2 => { power => 'off', network => 'off', maxcpu => 24, maxmem => 131072 }, - node3 => { power => 'off', network => 'off', maxcpu => 24, maxmem => 131072 }, + node1 => { power => 'off', network => 'off', maxcpu => 24.0, maxmem => 131072 }, + node2 => { power => 'off', network => 'off', maxcpu => 24.0, maxmem => 131072 }, + node3 => { power => 'off', network => 'off', maxcpu => 24.0, maxmem => 131072 }, }; $self->write_hardware_status_nolock($cstatus); } @@ -507,7 +507,7 @@ sub new { copy("$testdir/static_service_stats", "$statusdir/static_service_stats"); } else { my $services = $self->read_service_config(); - my $stats = { map { $_ => { maxcpu => 4, maxmem => 4096 } } keys %$services }; + my $stats = { map { $_ => { maxcpu => 4.0, maxmem => 4096 } } keys %$services }; $self->write_static_service_stats($stats); } @@ -883,7 +883,7 @@ sub sim_hardware_cmd { $self->set_static_service_stats( $sid, - { maxcpu => $params[0], maxmem => $params[1] }, + { maxcpu => 0.0 + $params[0], maxmem => int($params[1]) }, ); } elsif ($action eq 'manual-migrate') { -- 2.47.3