From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 34E3D1FF13C for ; Thu, 02 Apr 2026 14:50:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0E4A1774E; Thu, 2 Apr 2026 14:49:03 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v4 17/28] manager: rename execute_migration to queue_resource_motion Date: Thu, 2 Apr 2026 14:44:11 +0200 Message-ID: <20260402124817.416232-18-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402124817.416232-1-d.kral@proxmox.com> References: <20260402124817.416232-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775134043532 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BJRAD4Z6VFZ3O2SZBYLK6TZDCFF7PG5S X-Message-ID-Hash: BJRAD4Z6VFZ3O2SZBYLK6TZDCFF7PG5S X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The name is misleading, because the HA resource migration is not executed, but only queues the HA resource to change into the state 'migrate' or 'relocate', which is then picked up by the respective LRM to execute. The term 'resource motion' also generalizes the different actions implied by the 'migrate' and 'relocate' command and state. Signed-off-by: Daniel Kral Reviewed-by: Dominik Rusovac --- changes v3 -> v4: - none src/PVE/HA/Manager.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index c60ab595..c8a1a35b 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -419,7 +419,7 @@ sub read_lrm_status { return ($results, $modes); } -sub execute_migration { +sub queue_resource_motion { my ($self, $cmd, $task, $sid, $target) = @_; my ($haenv, $ss) = $self->@{qw(haenv ss)}; @@ -488,7 +488,7 @@ sub update_crm_commands { "ignore crm command - service already on target node: $cmd", ); } else { - $self->execute_migration($cmd, $task, $sid, $node); + $self->queue_resource_motion($cmd, $task, $sid, $node); } } } else { -- 2.47.3