From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AFCE91FF13A for ; Wed, 01 Apr 2026 16:09:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0309E1F12C; Wed, 1 Apr 2026 16:09:48 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Subject: [PATCH manager 3/3] api: backup: deprecate starttime and dow in create/update parameter schema Date: Wed, 1 Apr 2026 16:09:02 +0200 Message-ID: <20260401140903.364176-4-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401140903.364176-1-l.wagner@proxmox.com> References: <20260401140903.364176-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775052491134 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.447 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OBDZYRZPDKS6U7XN3L5U6WT2WMN3RYZJ X-Message-ID-Hash: OBDZYRZPDKS6U7XN3L5U6WT2WMN3RYZJ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When creating and updating backup jobs, the both parameters will be supported until further notice -- we only really should remove them in a major update -- but it definitely makes sense to mark them as deprecated in the parameter schema and document that these will be automatically translated into a matching 'schedule'. Signed-off-by: Lukas Wagner --- PVE/API2/Backup.pm | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 0683748e..3bd85593 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -269,18 +269,22 @@ __PACKAGE__->register_method({ maxLength => 128, optional => 1, }, + # FIXME: MAJOR VERSION: Drop this deprecated parameter. starttime => { type => 'string', - description => "Job Start time.", + description => "Deprecated: Use 'schedule' instead. Job Start time." + . " 'starttime' and 'dow' will be converted into 'schedule' if used.", pattern => '\d{1,2}:\d{1,2}', typetext => 'HH:MM', optional => 1, }, + # FIXME: MAJOR VERSION: Drop this deprecated parameter. dow => { type => 'string', format => 'pve-day-of-week-list', optional => 1, - description => "Day of week selection.", + description => "Deprecated: Use 'schedule' instead. Day of week selection." + . " 'starttime' and 'dow' will be converted into 'schedule' if used.", requires => 'starttime', default => ALL_DAYS, }, @@ -497,19 +501,23 @@ __PACKAGE__->register_method({ maxLength => 128, optional => 1, }, + # FIXME: MAJOR VERSION: Drop this deprecated parameter. starttime => { type => 'string', - description => "Job Start time.", + description => "Deprecated: Use 'schedule' instead. Job Start time." + . " 'starttime' and 'dow' will be converted into 'schedule' if used.", pattern => '\d{1,2}:\d{1,2}', typetext => 'HH:MM', optional => 1, }, + # FIXME: MAJOR VERSION: Drop this deprecated parameter. dow => { type => 'string', format => 'pve-day-of-week-list', optional => 1, requires => 'starttime', - description => "Day of week selection.", + description => "Deprecated: Use 'schedule' instead. Day of week selection." + . " 'starttime' and 'dow' will be converted into 'schedule' if used.", }, delete => { type => 'string', -- 2.47.3