From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CAAD01FF13A for ; Wed, 01 Apr 2026 14:59:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 980591B2FD; Wed, 1 Apr 2026 14:59:49 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 2/2] storage: content: show inaccessible RBD images in UI Date: Wed, 1 Apr 2026 20:59:33 +0800 Message-ID: <20260401125933.3643604-3-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401125933.3643604-1-k.chai@proxmox.com> References: <20260401125933.3643604-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775048328458 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.402 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XSQW4LZJMIHYKH7GX3DI6ZIQ4K2AQC2D X-Message-ID-Hash: XSQW4LZJMIHYKH7GX3DI6ZIQ4K2AQC2D X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When a corrupt or inaccessible RBD image is returned with size=-1 (introduced in the pve-storage rbd_ls() fix for bug #7000), render it as 'N/A (inaccessible)' instead of the nonsensical '-1 B'. Signed-off-by: Kefu Chai --- www/manager6/storage/ContentView.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 75b81e69..aa506887 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/ContentView.js @@ -187,7 +187,12 @@ Ext.define( size: { header: gettext('Size'), width: 100, - renderer: Proxmox.Utils.format_size, + renderer: function (v) { + if (v === -1) { + return gettext('N/A (inaccessible)'); + } + return Proxmox.Utils.format_size(v); + }, dataIndex: 'size', }, }; -- 2.47.3