From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B5B3F1FF137 for ; Tue, 31 Mar 2026 13:49:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E844F1A049; Tue, 31 Mar 2026 13:50:18 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 5/7] lvm plugin: activation: avoid extra variable Date: Tue, 31 Mar 2026 13:49:53 +0200 Message-ID: <20260331115011.102276-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com> References: <20260331115011.102276-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774957758654 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5FKAKRRH67UCKN7FATYGXHFW57IOPCE5 X-Message-ID-Hash: 5FKAKRRH67UCKN7FATYGXHFW57IOPCE5 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The value for the activation mode has been hardcoded since commit c8943a8 ("remove non used parameter exclusive"). Inline the value to avoid the extra variable and slightly improve readability. Signed-off-by: Fiona Ebner --- New in v2. src/PVE/Storage/LVMPlugin.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 7ef148b..79a52c5 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -957,15 +957,13 @@ sub activate_volume { my $path = $class->path($scfg, $volname, $storeid, $snapname); - my $lvm_activate_mode = 'ey'; - #activate volume && all snapshots volumes by tag my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = $class->parse_volname($volname); $path = "\@pve-$name" if $format eq 'qcow2'; - my $cmd = ['/sbin/lvchange', "-a$lvm_activate_mode", $path]; + my $cmd = ['/sbin/lvchange', '-aey', $path]; run_command($cmd, errmsg => "can't activate LV '$path'"); $cmd = ['/sbin/lvchange', '--refresh', $path]; run_command($cmd, errmsg => "can't refresh LV '$path' for activation"); -- 2.47.3