From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 770E41FF137 for ; Tue, 31 Mar 2026 03:27:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16BAEAE29; Tue, 31 Mar 2026 03:27:56 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 0/1] ceph: tools: fix local monitor detection in purge_all_ceph_files Date: Tue, 31 Mar 2026 09:27:45 +0800 Message-ID: <20260331012746.763863-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774920416346 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.142 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GXUKAFC42XCQKKRKAQ5MFK45HZEL5XXR X-Message-ID-Hash: GXUKAFC42XCQKKRKAQ5MFK45HZEL5XXR X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While reading the code, the call 'grep($addr, @$monlist)' caught my eye -- 'grep' made me think of grep(1), which takes a regular expression as its first argument. But the first argument here is clearly not a regex. That led me to https://perldoc.perl.org/functions/grep, where I read that grep(EXPR, LIST) evaluates EXPR for each element with $_ aliased to the current element -- similar to a lambda that takes $_ as its implicit parameter. The expression in our case, '$type->{$name}->{addr}', does not reference $_ at all, making it a constant predicate. It evaluates to the same value (the addr string) for every element in the list, so the result is the full list length rather than a membership test. I then searched for a Perl operator like 'in' or 'contains' to express membership directly, but found no such built-in. List::Util::any is the closest equivalent -- it makes the per-element comparison explicit and short-circuits on the first match. Kefu Chai (1): ceph: tools: fix local monitor detection in purge_all_ceph_files PVE/Ceph/Tools.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.47.3