From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0357B1FF137 for ; Tue, 31 Mar 2026 02:41:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D798AA69; Tue, 31 Mar 2026 02:42:00 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 0/1] pve8to9: fix package lookup empty result check Date: Tue, 31 Mar 2026 08:41:18 +0800 Message-ID: <20260331004119.707556-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774917630013 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.148 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IBCVSSTXQXZRO5J5GH3FSY6LOZUKLAVZ X-Message-ID-Hash: IBCVSSTXQXZRO5J5GH3FSY6LOZUKLAVZ X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I am new to Perl and noticed this while reading the code. I verified the bug with a small test: perl -e ' my $pkgs = [ grep { 0 } (1,2,3) ]; print "Defined\n" if defined $pkgs; print "Zero\n" if $pkgs == 0; ' Output: Defined '$pkgs == 0' printed nothing -- the array reference is never numerically zero, so the empty result check silently passed through even when the grep returned no results. Kefu Chai (1): pve8to9: fix package lookup empty result check PVE/CLI/pve8to9.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.3