From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 493BC1FF141 for ; Mon, 30 Mar 2026 16:47:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 553E427F0; Mon, 30 Mar 2026 16:46:42 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH manager 5/5] ui: cluster info: warn users of high token timeout in join info Date: Mon, 30 Mar 2026 16:43:21 +0200 Message-ID: <20260330144321.321072-6-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330144321.321072-1-m.koeppl@proxmox.com> References: <20260330144321.321072-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774881748557 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OZGYZI7Y3RUTSACRPLU5VWUD5L23Y3VH X-Message-ID-Hash: OZGYZI7Y3RUTSACRPLU5VWUD5L23Y3VH X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If another node would increase Corosync's token timeout to a level that might affect the stability of the cluster, display a warning hint to users, pointing them to the documentation section about changing the token coefficient, allowing them to make an informed change before another node. Signed-off-by: Michael Köppl --- www/manager6/dc/Cluster.js | 4 ++++ www/manager6/dc/ClusterEdit.js | 37 ++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/www/manager6/dc/Cluster.js b/www/manager6/dc/Cluster.js index 2ec5588c3..00138f328 100644 --- a/www/manager6/dc/Cluster.js +++ b/www/manager6/dc/Cluster.js @@ -91,6 +91,8 @@ Ext.define('PVE.ClusterAdministration', { vm.set('totem', data.totem); vm.set('isInCluster', !!data.totem.cluster_name); vm.set('nodelist', data.nodelist); + vm.set('expected_timeout', data.expected_timeout); + vm.set('timeout_warning_level', data.timeout_warning_level); let nodeinfo = data.nodelist.find((el) => el.name === data.preferred_node); @@ -133,6 +135,8 @@ Ext.define('PVE.ClusterAdministration', { peerLinks: vm.get('preferred_node.peerLinks'), ring_addr: vm.get('preferred_node.ring_addr'), totem: vm.get('totem'), + expected_timeout: vm.get('expected_timeout'), + timeout_warning_level: vm.get('timeout_warning_level'), }, }); }, diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/dc/ClusterEdit.js index aff1515ab..a1720dbca 100644 --- a/www/manager6/dc/ClusterEdit.js +++ b/www/manager6/dc/ClusterEdit.js @@ -55,6 +55,8 @@ Ext.define('PVE.ClusterInfoWindow', { ipAddress: undefined, fingerprint: undefined, totem: {}, + expected_timeout: undefined, + timeout_warning_level: undefined, }, initComponent: function () { @@ -113,6 +115,41 @@ Ext.define('PVE.ClusterInfoWindow', { }, ); + if (joinInfo.expected_timeout && joinInfo.timeout_warning_level) { + let level; + if (joinInfo.timeout_warning_level === 'change-strongly-recommended') { + level = gettext('Changing token coefficient is strongly recommended'); + } else if (joinInfo.timeout_warning_level === 'change-recommended') { + level = gettext('Changing token coefficient is recommended'); + } else if (joinInfo.timeout_warning_level === 'optimize') { + level = gettext('Token coefficient can be optimized'); + } + + let msg = Ext.String.format( + gettext( + "Adding another node will increase the sum of Corosync's token and consensus timeout to {0}s. {1}." + + ' See {2} for details.', + ), + joinInfo.expected_timeout, + level, + 'the documentation', + ); + + me.items.push({ + xtype: 'container', + border: false, + padding: '0 10 10 10', + items: [ + { + itemId: 'joinInfoWarningHint', + xtype: 'displayfield', + userCls: 'pmx-hint', + value: msg, + }, + ], + }); + } + me.callParent(); }, dockedItems: [ -- 2.47.3