From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E878D1FF141 for ; Mon, 30 Mar 2026 16:42:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3ABB36B57; Mon, 30 Mar 2026 16:41:49 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH perl-rs v3 10/40] pve-rs: resource-scheduling: remove pedantic error handling from remove_node Date: Mon, 30 Mar 2026 16:30:19 +0200 Message-ID: <20260330144101.668747-11-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330144101.668747-1-d.kral@proxmox.com> References: <20260330144101.668747-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774881613496 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KOJTILT7M6H3CMNAMUDVAJQWOFKTCFPM X-Message-ID-Hash: KOJTILT7M6H3CMNAMUDVAJQWOFKTCFPM X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The error can only happen due to an error in add_service_usage_to_node(...), but prevents all the following service_nodes entries from being cleaned up correctly. While technically a API break, removing the error does not change any callers, which do not handle the error anyway. Additionally, remove_node(...) is only used in testing code in this package and pve-ha-manager, but is currently unused for production code. This change makes the implementation more consistent with the new proxmox_resource_scheduling::usage::Usage, which will replace this in a following patch. Signed-off-by: Daniel Kral Reviewed-by: Dominik Rusovac --- changes v2 -> v3: - none pve-rs/src/bindings/resource_scheduling_static.rs | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/pve-rs/src/bindings/resource_scheduling_static.rs b/pve-rs/src/bindings/resource_scheduling_static.rs index 5b91d36..6e57b9d 100644 --- a/pve-rs/src/bindings/resource_scheduling_static.rs +++ b/pve-rs/src/bindings/resource_scheduling_static.rs @@ -75,25 +75,16 @@ pub mod pve_rs_resource_scheduling_static { /// Method: Remove a node from the scheduler. #[export] - pub fn remove_node(#[try_from_ref] this: &Scheduler, nodename: &str) -> Result<(), Error> { + pub fn remove_node(#[try_from_ref] this: &Scheduler, nodename: &str) { let mut usage = this.inner.lock().unwrap(); if let Some(node) = usage.nodes.remove(nodename) { for (sid, _) in node.services.iter() { - match usage.service_nodes.get_mut(sid) { - Some(service_nodes) => { - service_nodes.remove(nodename); - } - None => bail!( - "service '{}' not present in service_nodes hashmap while removing node '{}'", - sid, - nodename - ), + if let Some(service_nodes) = usage.service_nodes.get_mut(sid) { + service_nodes.remove(nodename); } } } - - Ok(()) } /// Method: Get a list of all the nodes in the scheduler. -- 2.47.3