From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0FA461FF140 for ; Fri, 27 Mar 2026 16:10:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84B4A1184B; Fri, 27 Mar 2026 16:10:52 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/1] ui: sdn: add BGP fabric support Date: Fri, 27 Mar 2026 16:10:31 +0100 Message-ID: <20260327151031.149360-7-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327151031.149360-1-h.laimer@proxmox.com> References: <20260327151031.149360-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774624195357 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DYAEU2WS2AFUVKIHP65QXOUDCPRCXA55 X-Message-ID-Hash: DYAEU2WS2AFUVKIHP65QXOUDCPRCXA55 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Register BGP as a fabric protocol in the UI. The fabric editor omits the ASN field since each node must specify its own unique ASN for eBGP unnumbered peering. The interface panel excludes the IP column since BGP unnumbered interfaces have no IP addresses. Signed-off-by: Hannes Laimer --- www/manager6/Makefile | 3 ++ www/manager6/sdn/FabricsView.js | 12 +++++ www/manager6/sdn/fabrics/NodeEdit.js | 1 + www/manager6/sdn/fabrics/bgp/FabricEdit.js | 52 +++++++++++++++++++ .../sdn/fabrics/bgp/InterfacePanel.js | 15 ++++++ www/manager6/sdn/fabrics/bgp/NodeEdit.js | 32 ++++++++++++ 6 files changed, 115 insertions(+) create mode 100644 www/manager6/sdn/fabrics/bgp/FabricEdit.js create mode 100644 www/manager6/sdn/fabrics/bgp/InterfacePanel.js create mode 100644 www/manager6/sdn/fabrics/bgp/NodeEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index da602523..d8a423e0 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -334,6 +334,9 @@ JSSRC= \ sdn/fabrics/ospf/InterfacePanel.js \ sdn/fabrics/ospf/NodeEdit.js \ sdn/fabrics/ospf/FabricEdit.js \ + sdn/fabrics/bgp/InterfacePanel.js \ + sdn/fabrics/bgp/NodeEdit.js \ + sdn/fabrics/bgp/FabricEdit.js \ storage/ContentView.js \ storage/BackupView.js \ storage/Base.js \ diff --git a/www/manager6/sdn/FabricsView.js b/www/manager6/sdn/FabricsView.js index 093a70f3..6b067247 100644 --- a/www/manager6/sdn/FabricsView.js +++ b/www/manager6/sdn/FabricsView.js @@ -33,6 +33,7 @@ Ext.define('PVE.sdn.Fabric.View', { const PROTOCOL_DISPLAY_NAMES = { openfabric: 'OpenFabric', ospf: 'OSPF', + bgp: 'BGP', }; const displayValue = PROTOCOL_DISPLAY_NAMES[value]; if (rec.data.state === undefined || rec.data.state === null) { @@ -194,6 +195,10 @@ Ext.define('PVE.sdn.Fabric.View', { text: 'OSPF', handler: 'addOspf', }, + { + text: 'BGP', + handler: 'addBgp', + }, ], }, addNodeButton, @@ -272,6 +277,7 @@ Ext.define('PVE.sdn.Fabric.View', { const FABRIC_PANELS = { openfabric: 'PVE.sdn.Fabric.OpenFabric.Fabric.Edit', ospf: 'PVE.sdn.Fabric.Ospf.Fabric.Edit', + bgp: 'PVE.sdn.Fabric.Bgp.Fabric.Edit', }; return FABRIC_PANELS[protocol]; @@ -281,6 +287,7 @@ Ext.define('PVE.sdn.Fabric.View', { const NODE_PANELS = { openfabric: 'PVE.sdn.Fabric.OpenFabric.Node.Edit', ospf: 'PVE.sdn.Fabric.Ospf.Node.Edit', + bgp: 'PVE.sdn.Fabric.Bgp.Node.Edit', }; return NODE_PANELS[protocol]; @@ -296,6 +303,11 @@ Ext.define('PVE.sdn.Fabric.View', { me.openFabricAddWindow('ospf'); }, + addBgp: function () { + let me = this; + me.openFabricAddWindow('bgp'); + }, + openFabricAddWindow: function (protocol) { let me = this; diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js index 161917cc..2e88b684 100644 --- a/www/manager6/sdn/fabrics/NodeEdit.js +++ b/www/manager6/sdn/fabrics/NodeEdit.js @@ -200,6 +200,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', { const INTERFACE_PANELS = { openfabric: 'PVE.sdn.Fabric.OpenFabric.InterfacePanel', ospf: 'PVE.sdn.Fabric.Ospf.InterfacePanel', + bgp: 'PVE.sdn.Fabric.Bgp.InterfacePanel', }; return INTERFACE_PANELS[protocol]; diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js new file mode 100644 index 00000000..1c37e533 --- /dev/null +++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js @@ -0,0 +1,52 @@ +Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', { + extend: 'PVE.sdn.Fabric.Fabric.Edit', + + subject: 'BGP', + + viewModel: { + data: { + showIpv6ForwardingHint: false, + }, + }, + + extraRequestParams: { + protocol: 'bgp', + }, + + additionalItems: [ + { + xtype: 'displayfield', + value: 'To make IPv6 fabrics work, enable global IPv6 forwarding on all nodes.', + bind: { + hidden: '{!showIpv6ForwardingHint}', + }, + userCls: 'pmx-hint', + }, + { + xtype: 'proxmoxtextfield', + fieldLabel: gettext('IPv6 Prefix'), + labelWidth: 120, + name: 'ip6_prefix', + allowBlank: true, + skipEmptyText: true, + cbind: { + disabled: '{!isCreate}', + deleteEmpty: '{!isCreate}', + }, + listeners: { + change: function (textbox, value) { + let vm = textbox.up('window').getViewModel(); + vm.set('showIpv6ForwardingHint', !!value); + }, + }, + }, + { + xtype: 'proxmoxcheckbox', + fieldLabel: gettext('BFD'), + labelWidth: 120, + name: 'bfd', + uncheckedValue: 0, + defaultValue: 0, + }, + ], +}); diff --git a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js new file mode 100644 index 00000000..81f3e849 --- /dev/null +++ b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js @@ -0,0 +1,15 @@ +Ext.define('PVE.sdn.Fabric.Bgp.InterfacePanel', { + extend: 'PVE.sdn.Fabric.InterfacePanel', + + // BGP unnumbered interfaces have no IP - override commonColumns to + // exclude the IP column that the base class defines. + initComponent: function () { + let me = this; + + me.commonColumns = me.commonColumns.filter( + (col) => col.dataIndex !== 'ip', + ); + + me.callParent(); + }, +}); diff --git a/www/manager6/sdn/fabrics/bgp/NodeEdit.js b/www/manager6/sdn/fabrics/bgp/NodeEdit.js new file mode 100644 index 00000000..4a172872 --- /dev/null +++ b/www/manager6/sdn/fabrics/bgp/NodeEdit.js @@ -0,0 +1,32 @@ +Ext.define('PVE.sdn.Fabric.Bgp.Node.Edit', { + extend: 'PVE.sdn.Fabric.Node.Edit', + protocol: 'bgp', + + extraRequestParams: { + protocol: 'bgp', + role: 'internal', + }, + + additionalItems: [ + { + xtype: 'proxmoxtextfield', + fieldLabel: gettext('IPv6'), + labelWidth: 120, + name: 'ip6', + allowBlank: true, + skipEmptyText: true, + cbind: { + deleteEmpty: '{!isCreate}', + }, + }, + { + xtype: 'proxmoxintegerfield', + fieldLabel: gettext('ASN'), + labelWidth: 120, + name: 'asn', + minValue: 1, + maxValue: 4294967295, + allowBlank: false, + }, + ], +}); -- 2.47.3