From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C5DA31FF13F for ; Thu, 26 Mar 2026 12:32:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D96BF842; Thu, 26 Mar 2026 12:33:01 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 1/2] backup: vma: add context to error message upon backup start Date: Thu, 26 Mar 2026 12:31:41 +0100 Message-ID: <20260326113251.68540-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260326113251.68540-1-f.ebner@proxmox.com> References: <20260326113251.68540-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774524726065 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HM5V6SYPYGP64YAHOZDI75VKOUBXYOPL X-Message-ID-Hash: HM5V6SYPYGP64YAHOZDI75VKOUBXYOPL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Upon failure, the queue_execute() function returns the error message from QEMU directly: > INFO: issuing guest-agent 'fs-freeze' command > INFO: issuing guest-agent 'fs-thaw' command > ERROR: Many such error messages mention internal QEMU functions and can be hard to interpret without knowledge of QEMU. Add some context to the error message to improve this: > INFO: issuing guest-agent 'fs-freeze' command > INFO: issuing guest-agent 'fs-thaw' command > ERROR: executing QMP command to start backup failed - In case of PBS and provider-based backups, mon_cmd() is used, which already includes the information which failed QMP command it is, for example, for PBS: > ERROR: VM 100 qmp command 'backup' failed - Signed-off-by: Fiona Ebner --- src/PVE/VZDump/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index 0681661d..2d55fbfa 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -1031,7 +1031,7 @@ sub archive_vma { $self->qga_fs_thaw($vmid); } - die $qmperr if $qmperr; + die "executing QMP command to start backup failed - $qmperr" if $qmperr; die $qmpclient->{errors}->{$vmid} if $qmpclient->{errors}->{$vmid}; if ($cpid) { -- 2.47.3