From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2C5591FF13B for ; Wed, 25 Mar 2026 22:01:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F6323495A; Wed, 25 Mar 2026 22:01:18 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 0/4] rework fs-freeze agent property Date: Wed, 25 Mar 2026 21:49:14 +0100 Message-ID: <20260325210021.3789748-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774472421083 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QN2IHY7OL4L6LFEUQXYRY6LFGZ6HC2YD X-Message-ID-Hash: QN2IHY7OL4L6LFEUQXYRY6LFGZ6HC2YD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Somewhat RFC, albeit I'm pretty sure about this the more I think about it, even though the transition cost is naturally not great. Very likely clashes with Fiona's recent QGA-skip-freeze-if-frozen series [0], but started this already a few days around and figured it might still be relevant in the current form. I probably would squash in the deprecation of the intermediate guest-fsfreeze variant with the commit making the long-time freeze-fs-on-backup property an alias to the new variant, which would be named 'freeze-fs' hereafter. [0]: https://lore.proxmox.com/all/20260324135325.120749-1-f.ebner@proxmox.com/ Thomas Lamprecht (4): agent: add should_fs_freeze helper agent: treat freeze-fs-on-backup as alias for guest-fsfreeze tests: cfg2cmd: add agent guest-fsfreeze config tests qga: rename guest-fsfreeze to freeze-fs src/PVE/API2/Qemu.pm | 10 +++--- src/PVE/QemuConfig.pm | 5 ++- src/PVE/QemuServer/Agent.pm | 35 ++++++++++++++----- src/PVE/VZDump/QemuServer.pm | 7 +--- .../cfg2cmd/qga-fs-freeze-backup-legacy.conf | 2 ++ .../qga-fs-freeze-backup-legacy.conf.cmd | 29 +++++++++++++++ src/test/cfg2cmd/qga-fs-freeze.conf | 2 ++ src/test/cfg2cmd/qga-fs-freeze.conf.cmd | 29 +++++++++++++++ src/test/cfg2cmd/qga-minimal.conf | 2 ++ src/test/cfg2cmd/qga-minimal.conf.cmd | 29 +++++++++++++++ 10 files changed, 126 insertions(+), 24 deletions(-) create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf.cmd create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf.cmd create mode 100644 src/test/cfg2cmd/qga-minimal.conf create mode 100644 src/test/cfg2cmd/qga-minimal.conf.cmd -- 2.47.3