From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0395E1FF13B for ; Wed, 25 Mar 2026 05:31:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A906C7F48; Wed, 25 Mar 2026 05:31:32 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ceph: init: drop deprecated pg_bits parameter Date: Wed, 25 Mar 2026 12:31:20 +0800 Message-ID: <20260325043120.2289935-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774413040189 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.385 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UWUJMSWR463V5FJBJMOJ37FE4XXL2QMF X-Message-ID-Hash: UWUJMSWR463V5FJBJMOJ37FE4XXL2QMF X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed from Ceph in v13.0.2. The implementation was made a no-op at that point, with a TODO to remove the parameter declaration in PVE 9. We are now at pve-manager 9.1.6. The minimum Ceph version supported by pveceph init is Nautilus (v14), which is already past the point where these options existed, so the parameter has been a guaranteed no-op on every cluster PVE 9 can manage. Remove it along with the adjacent dead-code comments. Signed-off-by: Kefu Chai --- PVE/API2/Ceph.pm | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 231b751c..f59caf16 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -161,17 +161,6 @@ __PACKAGE__->register_method({ minimum => 1, maximum => 7, }, - # TODO: deprecrated, remove with PVE 9 - pg_bits => { - description => "Placement group bits, used to specify the " - . "default number of placement groups.\n\nDepreacted. This " - . "setting was deprecated in recent Ceph versions.", - type => 'integer', - default => 6, - optional => 1, - minimum => 6, - maximum => 14, - }, disable_cephx => { description => "Disable cephx authentication.\n\n" . "WARNING: cephx is a security feature protecting against " @@ -238,9 +227,6 @@ __PACKAGE__->register_method({ 'mon_allow_pool_delete' => 'true', }; - # this does not work for default pools - #'osd pool default pg num' => $pg_num, - #'osd pool default pgp num' => $pg_num, } if ($auth eq 'cephx') { -- 2.47.3