From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CE02E1FF144 for ; Tue, 24 Mar 2026 19:30:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7078D194E0; Tue, 24 Mar 2026 19:30:40 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v2 06/40] resource-scheduling: topsis: handle empty criteria without panics Date: Tue, 24 Mar 2026 19:29:50 +0100 Message-ID: <20260324183029.1274972-7-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324183029.1274972-1-d.kral@proxmox.com> References: <20260324183029.1274972-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774376987968 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DUCQ5UUILK7APIAMO6AFRURVRKJCQ3MP X-Message-ID-Hash: DUCQ5UUILK7APIAMO6AFRURVRKJCQ3MP X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Iterator::min_by(...) and Iterator::max_by(...) do only return `None` if there are no entries in the `Matrix` column at all. This can only happen if the `Matrix` doesn't have any row entries. This will make any call to score_alternatives(...), the only current user of IdealAlternatives::compute(...), panic if there are no given alternatives. Therefore use reasonable default values. This has not happened yet, because the only non-test caller of score_alternatives(...) is score_nodes_to_start_resource(...), which always has nodes present in production. Signed-off-by: Daniel Kral --- changes v1 -> v2: - new! This can happen with the next patch if score_best_balancing_migration_candidates() is called with an empty candidates vec, which is trivially possible for pve-ha-manager in a cluster with high imbalance, but no configured HA resources or all HA resources being so constrainted that no migration is possible. proxmox-resource-scheduling/src/topsis.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/proxmox-resource-scheduling/src/topsis.rs b/proxmox-resource-scheduling/src/topsis.rs index 6d078aa6..ed5a9bd1 100644 --- a/proxmox-resource-scheduling/src/topsis.rs +++ b/proxmox-resource-scheduling/src/topsis.rs @@ -145,8 +145,10 @@ impl IdealAlternatives { let min = fixed_criterion .clone() .min_by(|a, b| a.total_cmp(b)) - .unwrap(); - let max = fixed_criterion.max_by(|a, b| a.total_cmp(b)).unwrap(); + .unwrap_or(f64::NEG_INFINITY); + let max = fixed_criterion + .max_by(|a, b| a.total_cmp(b)) + .unwrap_or(f64::INFINITY); (best[n], worst[n]) = match criteria[n].maximize { true => (max, min), -- 2.47.3