From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F23991FF144 for ; Tue, 24 Mar 2026 19:31:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EB8A1A2D8; Tue, 24 Mar 2026 19:31:20 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v2 23/40] sim: hardware: fix static stats guard Date: Tue, 24 Mar 2026 19:30:07 +0100 Message-ID: <20260324183029.1274972-24-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324183029.1274972-1-d.kral@proxmox.com> References: <20260324183029.1274972-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774376989092 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NCQ46TSWGIQC7ASQYGIZP2PN675RIEHO X-Message-ID-Hash: NCQ46TSWGIQC7ASQYGIZP2PN675RIEHO X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dominik Rusovac While falsy, values of 0 or 0.0 are valid stats. Hence, use 'defined'-check to avoid skipping falsy static service stats. Signed-off-by: Dominik Rusovac Signed-off-by: Daniel Kral --- changes v1 -> v2: - new! wrt v1: - do not skip falsy stats src/PVE/HA/Sim/Hardware.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 47839112..c167abd7 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -202,11 +202,11 @@ sub set_static_service_stats { my $stats = $self->read_static_service_stats(); - if (my $memory = $new_stats->{maxmem}) { + if (defined(my $memory = $new_stats->{maxmem})) { $stats->{$sid}->{maxmem} = $memory; } - if (my $cpu = $new_stats->{maxcpu}) { + if (defined(my $cpu = $new_stats->{maxcpu})) { $stats->{$sid}->{maxcpu} = $cpu; } -- 2.47.3