From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5EB421FF144 for ; Tue, 24 Mar 2026 14:53:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48088129CE; Tue, 24 Mar 2026 14:53:33 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/8] api: clone/import: fix check if agent is enabled Date: Tue, 24 Mar 2026 14:50:42 +0100 Message-ID: <20260324135325.120749-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324135325.120749-1-f.ebner@proxmox.com> References: <20260324135325.120749-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774360362207 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BYXASYDKAMYZ3RKWYGTDGGVXM3ILGQAE X-Message-ID-Hash: BYXASYDKAMYZ3RKWYGTDGGVXM3ILGQAE X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Just checking whether the configuration is present does not mean that the guest agent is enabled. Explicitly check the 'enabled' property. In case of snapshot, this is already done. This avoids a log message about the agent not running, since there is no device added to the QEMU commandline for communicating with the agent if disabled. Signed-off-by: Fiona Ebner --- src/PVE/API2/Qemu.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index b409610c..1752f46a 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -374,7 +374,7 @@ my $import_from_volid = sub { my ($src_storeid) = PVE::Storage::parse_volume_id($src_volid); - my $qga = $src_conf->{agent} + my $qga = PVE::QemuServer::Agent::get_qga_key($src_conf, 'enabled') && (PVE::QemuServer::Agent::get_qga_key($src_conf, 'guest-fsfreeze') // 1); return PVE::QemuServer::clone_disk( @@ -4562,7 +4562,7 @@ __PACKAGE__->register_method({ $dest_info->{efisize} = PVE::QemuServer::get_efivars_size($oldconf) if $opt eq 'efidisk0'; - my $qga = $oldconf->{agent} + my $qga = PVE::QemuServer::Agent::get_qga_key($oldconf, 'enabled') && (PVE::QemuServer::Agent::get_qga_key($oldconf, 'guest-fsfreeze') // 1); my $newdrive = PVE::QemuServer::clone_disk( -- 2.47.3