From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BA9D11FF144 for ; Tue, 24 Mar 2026 14:54:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CAD8D13429; Tue, 24 Mar 2026 14:54:04 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server 0/8] fix #7383: agent: fsfreeze: skip freeze if already frozen Date: Tue, 24 Mar 2026 14:50:40 +0100 Message-ID: <20260324135325.120749-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774360362095 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JYS32H72NQECRJE7YDMCOOBWAOSEOPIW X-Message-ID-Hash: JYS32H72NQECRJE7YDMCOOBWAOSEOPIW X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The series is structured as follows: The first patch is an independent fix for a long-standing issue that the result of the guest-fsfreeze-thaw command was not checked. The next two patches fix checking whether the agent is enabled for backup and clone/import, which in practice avoids a warning about the agent not running if explicitly disabled. The next four patches lead up to harmonizing the checks before freeze which previously were duplicated to three different places and improve encapsulation of the agent module. The last patch closes bug #7383 and checks if the filesystem is already frozen before attempting freeze to avoid a confusing error message. qemu-server: Fiona Ebner (8): agent: fs thaw: check command result api: clone/import: fix check if agent is enabled backup: freeze: fix check if agent is enabled agent: parse: change signature to take property string rather than full VM config agent: get qga key: change signature to take property string rather than full VM config clone disk/block jobs: change signatures to take guest agent property string agent: fsfreeze: harmonize checks for guest fs freeze fix #7383: agent: fsfreeze: skip freeze if already frozen src/PVE/API2/Qemu.pm | 15 ++---- src/PVE/QemuConfig.pm | 14 ++---- src/PVE/QemuMigrate.pm | 2 +- src/PVE/QemuServer.pm | 14 ++++-- src/PVE/QemuServer/Agent.pm | 89 +++++++++++++++++++++++++++++++--- src/PVE/QemuServer/BlockJob.pm | 15 ++---- src/PVE/VZDump/QemuServer.pm | 20 +++----- 7 files changed, 114 insertions(+), 55 deletions(-) Summary over all repositories: 7 files changed, 114 insertions(+), 55 deletions(-) -- Generated by git-murpp 0.5.0