From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B15B91FF144 for ; Tue, 24 Mar 2026 13:49:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8245F5AD; Tue, 24 Mar 2026 13:49:58 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 1/2] api: assert validity of resources param only if defined Date: Tue, 24 Mar 2026 13:49:20 +0100 Message-ID: <20260324124921.148515-2-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324124921.148515-1-m.koeppl@proxmox.com> References: <20260324124921.148515-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774356548079 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BOYILYFM6KZWZ7T6YY4NGUBDOREEPQWQ X-Message-ID-Hash: BOYILYFM6KZWZ7T6YY4NGUBDOREEPQWQ X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The check for the validity of the resources param should only be performed if the param was even defined, since it is not a required parameter for updating a rule. Previously, when not setting the resources field as part of the request, the check in the assert function would fail due to using undefined as a hash reference, which would stop users from updating a rule. Signed-off-by: Michael Köppl --- src/PVE/API2/HA/Rules.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/HA/Rules.pm b/src/PVE/API2/HA/Rules.pm index f09ab36..0b44d51 100644 --- a/src/PVE/API2/HA/Rules.pm +++ b/src/PVE/API2/HA/Rules.pm @@ -343,7 +343,7 @@ __PACKAGE__->register_method({ my $plugin = PVE::HA::Rules->lookup($type); my $opts = $plugin->check_config($ruleid, $param, 0, 1); - $assert_valid_resources_param->($opts->{resources}); + $assert_valid_resources_param->($opts->{resources}) if $opts->{resources}; $assert_valid_nodes_param->($opts->{nodes}) if $opts->{nodes}; my $options = $plugin->private()->{options}->{$type}; -- 2.47.3