From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9A4DD1FF141 for ; Mon, 16 Mar 2026 13:38:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B6A7518F3F; Mon, 16 Mar 2026 13:38:59 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH container/qemu-server v3 0/2] api: clone: print a message with new VMID Date: Mon, 16 Mar 2026 13:38:17 +0100 Message-ID: <20260316123820.333308-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773664660650 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.951 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4L7WWZL4IWTSTMHT7M54TSZ7SCK3OV72 X-Message-ID-Hash: 4L7WWZL4IWTSTMHT7M54TSZ7SCK3OV72 X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Note that when creating linked clones we do not update the creation time (commits) in the config. When cloning two VMs from a template (created with "vanilla" settings), if one uses the same 'name' for both clones, then the only differences between the linked clones that could be used to tell them apart are the MAC address, the VM id, smbios UUID, and the vmgenid, all of which are randomly generated. I think it makes sense to update the creation time too. But for now, being able to tell from the task log which VM correspond to which qmclone task would be an improvement already. Tested: - create a template with id 101 - running: qm clone 101 206 --full 0, and checking its output creating a clone of 101 with ID 206 create linked clone of drive scsi0 (local-lvm:base-101-disk-0) Differences from v2: - s/creating a clone of $vmid/creating a clone of VM $vmi - Add a similar line to pve-container's clone Differences from v1: - Moved the message to the start of $clonefn qemu-server: Maximiliano Sandoval (1): api: qmclone: print a message with new VMID src/PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) pve-container: Maximiliano Sandoval (1): api: vm_clone: print a message with new VMID src/PVE/API2/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) Summary over all repositories: 2 files changed, 5 insertions(+), 0 deletions(-) -- Generated by murpp 0.10.0