From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 43F2E1FF141 for ; Mon, 16 Mar 2026 11:14:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8CD114981; Mon, 16 Mar 2026 11:14:11 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2] api: qmclone: print a message with new VMID Date: Mon, 16 Mar 2026 11:14:04 +0100 Message-ID: <20260316101405.174423-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773656005596 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WIU7BDDFK7QJO4FB32TCFUAE54IWHZGY X-Message-ID-Hash: WIU7BDDFK7QJO4FB32TCFUAE54IWHZGY X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When doing a linked clone of a template, the task log, journal, nor the UPID of the task will log the VMID of the newly created VM. We add a log message at the start of the clone. This affects both full and linked clones. Signed-off-by: Maximiliano Sandoval --- Notes: Note that when creating linked clones we do not update the creation time in the config. When cloning two VMs from a template (created with "vanilla" settings), if one uses the same 'name' for both clones, then the only differences between the linked clones that could be used to tell them apart are the MAC address, the VM id, smbios UUID, and the vmgenid, all of which are randomly generated. I think it makes sense to update the creation time too. But for now, being able to tell from the task log which VM correspond to which qmclone task would be an improvement already. Tested: - create a template with id 101 - running: qm clone 101 206 --full 0, and checking its output creating a clone of 101 with ID 206 create linked clone of drive scsi0 (local-lvm:base-101-disk-0) Differences from v1: - Moved the message to the start of $clonefn src/PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 1e226f6f..0587ff97 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -4487,6 +4487,9 @@ __PACKAGE__->register_method({ my $clonefn = sub { my ($conffile, $newconf, $oldconf, $vollist, $drives, $fullclone) = $load_and_check->(); + + print("creating a clone of $vmid with ID $newid\n"); + my $storecfg = PVE::Storage::config(); # auto generate a new uuid -- 2.47.3