From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4D3D91FF140 for ; Fri, 13 Mar 2026 10:56:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1EA37DD36; Fri, 13 Mar 2026 10:56:11 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally Date: Fri, 13 Mar 2026 10:55:33 +0100 Message-ID: <20260313095534.79526-8-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260313095534.79526-1-m.sandoval@proxmox.com> References: <20260313095534.79526-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773395697661 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2CJXS3O6KFYQGWAKLNA42HIGBEPN6EHS X-Message-ID-Hash: 2CJXS3O6KFYQGWAKLNA42HIGBEPN6EHS X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the freeze-fs-on-backup key is not explicitly set on the config file or if it is explicitly enabled (which matches its default) we hide the corresponding checkbox and hint. Note that when the checkbox is unchecked we delete the value from the config. A consequence of this is that if the deprecated key is explicitly set `freeze-fs-on-backup=1`, we open the dialog, change some unrelated setting (so that the OK button becomes sensitive), press OK to save the settings, then the deprecated key freeze-fs-on-backup key would be gone from the config. Signed-off-by: Maximiliano Sandoval --- www/manager6/form/AgentFeatureSelector.js | 27 ++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js index 39ee211a..51d9d94e 100644 --- a/www/manager6/form/AgentFeatureSelector.js +++ b/www/manager6/form/AgentFeatureSelector.js @@ -2,7 +2,18 @@ Ext.define('PVE.form.AgentFeatureSelector', { extend: 'Proxmox.panel.InputPanel', alias: ['widget.pveAgentFeatureSelector'], - viewModel: {}, + viewModel: { + data: { + hideFreezeFsOnBackup: true, + freezeFsOnBackupChecked: true, + }, + + formulas: { + hideFreezeFsOnBackupNotes: function (get) { + return get('freezeFsOnBackupChecked') || get('hideFreezeFsOnBackup'); + }, + }, + }, items: [ { @@ -75,9 +86,10 @@ Ext.define('PVE.form.AgentFeatureSelector', { 'Freeze/thaw guest filesystems on backup for consistency. Deprecated in favor of the more general setting.', ), name: 'freeze-fs-on-backup', - reference: 'freeze_fs_on_backup', bind: { disabled: '{!enabled.checked}', + value: '{freezeFsOnBackupChecked}', + hidden: '{hideFreezeFsOnBackup}', }, disabled: true, uncheckedValue: '0', @@ -90,7 +102,7 @@ Ext.define('PVE.form.AgentFeatureSelector', { 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk backups.', ), bind: { - hidden: '{freeze_fs_on_backup.checked}', + hidden: '{hideFreezeFsOnBackupNotes}', }, }, ], @@ -109,8 +121,17 @@ Ext.define('PVE.form.AgentFeatureSelector', { setValues: function (values) { let me = this; + let vm = me.getViewModel(); let res = PVE.Parser.parsePropertyString(values.agent, 'enabled'); + + // We hide the switch for the deprecated freeze-fs-on-backup if the setting was not + // explicitly set by the user or if was explicitly enabled. + vm.set( + 'hideFreezeFsOnBackup', + !Ext.isDefined(res['freeze-fs-on-backup']) || res['freeze-fs-on-backup'] === '1', + ); + if (!Ext.isDefined(res['freeze-fs-on-backup'])) { res['freeze-fs-on-backup'] = 1; } -- 2.47.3