From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9CD371FF13F for ; Thu, 12 Mar 2026 19:27:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6147A538; Thu, 12 Mar 2026 19:27:23 +0100 (CET) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH container] api: template: allow creating template from ct with disk on LVM Date: Thu, 12 Mar 2026 19:27:05 +0100 Message-ID: <20260312182714.108583-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773340002657 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.536 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S722HO2VW5IRNBA5PCVCXPGXKHHKKUO5 X-Message-ID-Hash: S722HO2VW5IRNBA5PCVCXPGXKHHKKUO5 X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently, in the UI, one can create a template from a VM with a disk on LVM storage, but not from a container. This is because the LVM plugin does not have the functionality to create base images from disks implemented. While the system simply skips this function for VMs, it throws an error and aborts for LXC containers. To allow converting to a template, skip the volumes where the required functionality is not present by exiting early instead of aborting. Signed-off-by: Lukas Sichert --- src/PVE/LXC.pm | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index caba952..e77d208 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1613,17 +1613,7 @@ sub template_create { my $volid = $mountpoint->{volume}; - die "Template feature is not available for '$volid'\n" - if !PVE::Storage::volume_has_feature($storecfg, 'template', $volid); - }, - ); - - PVE::LXC::Config->foreach_volume( - $conf, - sub { - my ($ms, $mountpoint) = @_; - - my $volid = $mountpoint->{volume}; + return if !PVE::Storage::volume_has_feature($storecfg, 'template', $volid); PVE::Storage::activate_volumes($storecfg, [$volid]); -- 2.47.3