From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EC0201FF13F for ; Thu, 12 Mar 2026 15:54:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B356C1CE33; Thu, 12 Mar 2026 15:54:32 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 0/3] memory: add verbose_description to NUMA policy Date: Thu, 12 Mar 2026 15:54:19 +0100 Message-ID: <20260312145423.434537-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773327227168 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.959 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LUW7G4I5C3JV5H6B7I7ZF35O2CP3FBUV X-Message-ID-Hash: LUW7G4I5C3JV5H6B7I7ZF35O2CP3FBUV X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adds a more flavorful description to the NUMA policy option based on both qemu and the kernel's documentation. For now we simply paste the contents of the `qemu-system-x86_64(1)` manual. One open question is if there is any precedent for URIs in verbose descriptions. This came up in a couple of cases in enterprise support where information was requested regarding the NUMA policy. Regarding the 'default' value. NUMA policies were added on our side at 2ed5d5724 but there is no mention of why the 'default' policy is not used as a default. On QEMU's side the first appearance of policies was a 2.1.0 (Aug 2014) and there was a 'default' value at that stage. While one could use the 'default' policy when the property is not set, I personally would prefer if "not setting the key in the config" can be represented by an explicit value in the config. What was tested: - Create a VM with 2048 MiB of ram and 1 CPU with numa enabled - Ran: - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0 - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=default - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=bind - Verify in each case that the memory-backend-ram has the right policy in the qm showcmd 100 output Differences from v1: - Add more to the commit messages - sed s/numa/NUMA - Read default value from the schema directly - Sneak a commit fixing the unit in a comment - Say what was tested in cover letter - Explain why a default value was added to the schema instead of just using it instead of dying in the cover letter Maximiliano Sandoval (3): memory: add verbose_description to NUMA policy memory: add default NUMA allocation policy memory: fix unit in heuristic comment src/PVE/QemuServer/Memory.pm | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) -- 2.47.3