From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id E29AB1FF13F
	for <inbox@lore.proxmox.com>; Thu, 12 Mar 2026 11:50:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1694210E8C;
	Thu, 12 Mar 2026 11:50:50 +0100 (CET)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 2/2] memory: add default numa allocation policy
Date: Thu, 12 Mar 2026 11:50:17 +0100
Message-ID: <20260312105044.191421-3-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260312105044.191421-1-m.sandoval@proxmox.com>
References: <20260312105044.191421-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1773312609223
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.105 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: TBIGUDWHF3LDXBG4ETG6H5SD3NYNJ3XG
X-Message-ID-Hash: TBIGUDWHF3LDXBG4ETG6H5SD3NYNJ3XG
X-MailFrom: m.sandoval@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

This follows the host numa policy.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/QemuServer/Memory.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/PVE/QemuServer/Memory.pm b/src/PVE/QemuServer/Memory.pm
index bcf6f9c5..9e65b2b0 100644
--- a/src/PVE/QemuServer/Memory.pm
+++ b/src/PVE/QemuServer/Memory.pm
@@ -40,11 +40,12 @@ my $numa_fmt = {
     },
     policy => {
         type => 'string',
-        enum => [qw(preferred bind interleave)],
+        enum => [qw(default preferred bind interleave)],
         description => "NUMA allocation policy.",
         verbose_description => <<EODESC,
 NUMA allocation policy. Possible values are:
 
+ - default: default host policy
  - preferred: prefer the given host node list for allocation
  - bind: restrict memory allocation to the given host node list
  - interleave: interleave memory allocations across the given host node list
@@ -53,6 +54,7 @@ The models are explained in more details at the kernel's documentation
 https://docs.kernel.org/admin-guide/mm/numa_memory_policy.html#components-of-memory-policies.
 EODESC
         optional => 1,
+        default => 'default',
     },
 };
 PVE::JSONSchema::register_format('pve-qm-numanode', $numa_fmt);
@@ -450,8 +452,7 @@ sub config {
                 my $hostnodes = print_numa_hostnodes($hostnodelists);
 
                 # policy
-                my $policy = $numa->{policy};
-                die "you need to define a policy for hostnode $hostnodes\n" if !$policy;
+                my $policy = $numa->{policy} // 'default';
                 $mem_object .= ",host-nodes=$hostnodes,policy=$policy";
             } else {
                 die "numa hostnodes need to be defined to use hugepages" if $conf->{hugepages};
-- 
2.47.3