From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6FB31FF13F for ; Thu, 12 Mar 2026 11:13:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA471E108; Thu, 12 Mar 2026 11:13:31 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager] fix #7337: Keep track of deep link on OpenID login Date: Thu, 12 Mar 2026 11:12:27 +0100 Message-ID: <20260312101227.212668-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: 7HSEE4T4ZKKYDGFHGQBWE554OQK7P75L X-Message-ID-Hash: 7HSEE4T4ZKKYDGFHGQBWE554OQK7P75L X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously, when opening a deep link without being logged into PVE, the hash was getting lost, redirecting the user to / instead of /#. Store `window.location.hash` in sessionStorage (per-tab storage) before redirecting to the login URL, and add it to `Ext.History` after successful login to direct the user to the deeplink they opened. Signed-off-by: Arthur Bied-Charreton --- www/manager6/Workspace.js | 5 +++++ www/manager6/window/LoginWindow.js | 1 + 2 files changed, 6 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index b8061c2a..0f0e6ffb 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -49,6 +49,11 @@ Ext.define('PVE.Workspace', { handler: function (data) { me.login = null; me.updateLoginData(data); + let deeplink = sessionStorage.getItem('openid-deeplink'); + if (deeplink) { + sessionStorage.removeItem('openid-deeplink'); + Ext.History.add(deeplink); + } Proxmox.Utils.checked_command(Ext.emptyFn); // display subscription status }, }); diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js index 324861ec..aacb8f2f 100644 --- a/www/manager6/window/LoginWindow.js +++ b/www/manager6/window/LoginWindow.js @@ -50,6 +50,7 @@ Ext.define('PVE.window.LoginWindow', { if (this.getViewModel().data.openid === true) { const redirectURL = location.origin; + sessionStorage.setItem('openid-deeplink', window.location.hash); Proxmox.Utils.API2Request({ url: '/api2/extjs/access/openid/auth-url', params: { -- 2.47.3