From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B2BA31FF13F for ; Thu, 12 Mar 2026 09:41:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6511B9AC3; Thu, 12 Mar 2026 09:41:01 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 2/8] ui: CPUModelSelector: Fix dirty state on default Date: Thu, 12 Mar 2026 09:40:15 +0100 Message-ID: <20260312084021.124465-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260312084021.124465-1-a.bied-charreton@proxmox.com> References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.105 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: P47OQDOVTFOGHVESQL6YZUSALTSEPGHP X-Message-ID-Hash: P47OQDOVTFOGHVESQL6YZUSALTSEPGHP X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefan Reiter X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 'originalValue' is set to null in case it's the default, but getValue returns an empty string. This means that when editing a VM's CPU config when the model is 'default', the form would always be marked dirty. Original patch: https://lore.proxmox.com/pve-devel/20211028114150.3245864-7-s.reiter@proxmox.com/ Originally-by: Stefan Reiter Signed-off-by: Arthur Bied-Charreton --- www/manager6/form/CPUModelSelector.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js index 2ebd08eb..737b6ff4 100644 --- a/www/manager6/form/CPUModelSelector.js +++ b/www/manager6/form/CPUModelSelector.js @@ -39,7 +39,11 @@ Ext.define('PVE.form.CPUModelSelector', { ], width: 360, }, - + getValue: function () { + let me = this; + let val = me.callParent(); + return val === '' ? null : val; + }, store: { autoLoad: true, model: 'PVE.data.CPUModel', -- 2.47.3