From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1B231FF13F for ; Thu, 12 Mar 2026 09:40:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE20E8FD2; Thu, 12 Mar 2026 09:40:26 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/8] ui: VMCPUFlagSelector: Fix unknownFlags behaviour Date: Thu, 12 Mar 2026 09:40:14 +0100 Message-ID: <20260312084021.124465-2-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260312084021.124465-1-a.bied-charreton@proxmox.com> References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: E2XPMOHM4MGOX76OYOM25ZET237TKIAT X-Message-ID-Hash: E2XPMOHM4MGOX76OYOM25ZET237TKIAT X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefan Reiter X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ...and typo in name. Original patch: https://lore.proxmox.com/pve-devel/20211028114150.3245864-6-s.reiter@proxmox.com/ Originally-by: Stefan Reiter Signed-off-by: Arthur Bied-Charreton --- www/manager6/form/VMCPUFlagSelector.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index 922fcfa6..74b1a2c4 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -14,7 +14,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { scrollable: 'y', height: 200, - unkownFlags: [], + unknownFlags: [], store: { type: 'store', @@ -62,32 +62,32 @@ Ext.define('PVE.form.VMCPUFlagSelector', { } }); - flags += me.unkownFlags.join(';'); + flags += (me.unknownFlags.length > 0 ? ';' : '') + me.unknownFlags.join(';'); return flags; }, - // Adjusts the store for the current value and determines the unkown flags based on what the + // Adjusts the store for the current value and determines the unknown flags based on what the // store does not know. adjustStoreForValue: function () { let me = this; let store = me.getStore(); let value = me.value; - me.unkownFlags = []; + me.unknownFlags = []; store.getData().each((rec) => rec.set('state', '=')); let flags = value ? value.split(';') : []; flags.forEach(function (flag) { let sign = flag.substr(0, 1); - flag = flag.substr(1); + let flagName = flag.substr(1); - let rec = store.findRecord('name', flag, 0, false, true, true); + let rec = store.findRecord('name', flagName, 0, false, true, true); if (rec !== null) { rec.set('state', sign); } else { - me.unkownFlags.push(flag); + me.unknownFlags.push(flag); } }); -- 2.47.3