From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A88911FF13F for ; Thu, 12 Mar 2026 09:39:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6CCB8E27; Thu, 12 Mar 2026 09:39:53 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v2] lrm: fix typos in log messages Date: Thu, 12 Mar 2026 09:39:16 +0100 Message-ID: <20260312083916.49513-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773304724849 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.737 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4YZLWC67RFEOOHGM6IPGFTYJ66UQ6T7Q X-Message-ID-Hash: 4YZLWC67RFEOOHGM6IPGFTYJ66UQ6T7Q X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Dominik Rusovac --- changes since v1: * adjust regression test affected by changes src/PVE/HA/LRM.pm | 6 +++--- src/test/test-stale-maintenance-node/log.expect | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm index e4b0ec8..09a965c 100644 --- a/src/PVE/HA/LRM.pm +++ b/src/PVE/HA/LRM.pm @@ -376,7 +376,7 @@ sub work { } elsif ($state eq 'active') { if ($fence_request) { - $haenv->log('err', "node need to be fenced - releasing agent_lock\n"); + $haenv->log('err', "node needs to be fenced - releasing agent_lock\n"); $self->set_local_status({ state => 'lost_agent_lock' }); } elsif (!$self->get_protected_ha_agent_lock()) { $self->set_local_status({ state => 'lost_agent_lock' }); @@ -406,7 +406,7 @@ sub work { if ($fence_request) { $haenv->log( 'err', - "node need to be fenced during maintenance mode - releasing agent_lock\n", + "node needs to be fenced during maintenance mode - releasing agent_lock\n", ); $self->set_local_status({ state => 'lost_agent_lock' }); } elsif ($self->active_service_count() || $self->run_workers()) { @@ -518,7 +518,7 @@ sub work { if ($service_count > 0) { $haenv->log( 'err', - "get shutdown request in state 'lost_agent_lock' - " + "got shutdown request in state 'lost_agent_lock' - " . "detected $service_count running services", ); diff --git a/src/test/test-stale-maintenance-node/log.expect b/src/test/test-stale-maintenance-node/log.expect index 2713132..092db8b 100644 --- a/src/test/test-stale-maintenance-node/log.expect +++ b/src/test/test-stale-maintenance-node/log.expect @@ -47,9 +47,9 @@ info 144 shutdown: execute power node3 off info 160 node1/crm: status change master => lost_manager_lock info 160 node1/crm: status change lost_manager_lock => wait_for_quorum info 161 node1/lrm: status change maintenance => lost_agent_lock -err 161 node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services -err 181 node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services -err 201 node1/lrm: get shutdown request in state 'lost_agent_lock' - detected 1 running services +err 161 node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services +err 181 node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services +err 201 node1/lrm: got shutdown request in state 'lost_agent_lock' - detected 1 running services info 202 watchdog: execute power node1 off info 201 node1/crm: killed by poweroff info 202 node1/lrm: killed by poweroff -- 2.47.3