From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 040581FF13B for ; Wed, 11 Mar 2026 13:50:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB4E919D13; Wed, 11 Mar 2026 13:50:47 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 1/2] rules: ensure rule is defined and has type in set_rule_defaults Date: Wed, 11 Mar 2026 13:49:35 +0100 Message-ID: <20260311125008.271334-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311125008.271334-1-d.kral@proxmox.com> References: <20260311125008.271334-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773233377031 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: H456BNMRGH3V27NMIOJ3VVEJCO65EXRK X-Message-ID-Hash: H456BNMRGH3V27NMIOJ3VVEJCO65EXRK X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the rule is not defined or does not have a type set, there are no optional property defaults to set. This prevents users of set_rule_defaults(...) to have to deal with unnecessary error handling. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7399 Signed-off-by: Daniel Kral --- src/PVE/HA/Rules.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm index 38c57548..3a14eeb3 100644 --- a/src/PVE/HA/Rules.pm +++ b/src/PVE/HA/Rules.pm @@ -274,7 +274,8 @@ haven't been explicitly set yet. sub set_rule_defaults { my ($class, $rule) = @_; - if (my $plugin = $class->lookup($rule->{type})) { + if ($rule && $rule->{type}) { + my $plugin = $class->lookup($rule->{type}); my $properties = $plugin->properties(); for my $prop (keys %$properties) { -- 2.47.3