From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D10061FF13B for ; Wed, 11 Mar 2026 13:50:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 364F719A7C; Wed, 11 Mar 2026 13:50:16 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 0/2] fix #7399: check if required rule props are set Date: Wed, 11 Mar 2026 13:49:34 +0100 Message-ID: <20260311125008.271334-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773233376970 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LH6BGBBCXOCAILMN2VG4TWTRD6S4JBDU X-Message-ID-Hash: LH6BGBBCXOCAILMN2VG4TWTRD6S4JBDU X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The API endpoints allow users to set empty 'nodes' and 'resources' properties for HA rules, which are not handled by the api schema verification nor the api handlers themselves. PATCH 1 fixes the got unexpected error - cannot lookup undefined type! at /usr/share/perl5/PVE/HA/Config.pm line 232. error message for existing configs with invalid sections, which prevents the CRM from doing any other progress. It will only keep logging the hint that a section misses a required option. PATCH 2 prevents users from passing empty strings for the 'nodes' and 'resources' parameters, which are catched before these are written to the rules config itself. A more general solution is proposed in [0], which fixes this behavior in PVE::SectionConfig itself. [0] https://lore.proxmox.com/pve-devel/20260311122659.250421-1-d.kral@proxmox.com/ Daniel Kral (2): rules: ensure rule is defined and has type in set_rule_defaults api: rules: check for non-empty nodes and resources properties src/PVE/API2/HA/Rules.pm | 16 ++++++++++------ src/PVE/HA/Rules.pm | 3 ++- 2 files changed, 12 insertions(+), 7 deletions(-) -- 2.47.3