From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D3E421FF13B for ; Wed, 11 Mar 2026 10:45:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AFA851264F; Wed, 11 Mar 2026 10:45:18 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Date: Wed, 11 Mar 2026 10:44:47 +0100 Message-ID: <20260311094506.22359-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com> References: <20260311094506.22359-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773222275419 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.501 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Message-ID-Hash: BKNPBWV2AGYQYH3XVWAG6WGT2RCFN4OQ X-Message-ID-Hash: BKNPBWV2AGYQYH3XVWAG6WGT2RCFN4OQ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The 'order' property is only used for external snapshots. For internal qcow2 snapshots, when a new snapshot is taken, the ID is one more than the highest currently present ID. Thus, the order is currently reversed compared to the one for the external snapshot backing chain, where images further back in the chain have higher IDs. Just drop the information, since it is not used. The qcow2 ID cannot be used for the 'id' property for replication either, because two snapshots with the same name might end up with the same ID, which violates a requirement. Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 042e599..9dbdef6 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1916,7 +1916,6 @@ sub volume_snapshot_info { my $snapshots = $json_decode->{snapshots}; for my $snap (@$snapshots) { my $snapname = $snap->{name}; - $info->{$snapname}->{order} = $snap->{id}; $info->{$snapname}->{timestamp} = $snap->{'date-sec'}; } -- 2.47.3